| Message ID | 1250614778.2782.14.camel@achroite |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Ben Hutchings <bhutchings@solarflare.com> Date: Tue, 18 Aug 2009 17:59:38 +0100 > I misunderstood the meaning of __bitwise. In practice it makes sparse > warn about every use of mmds which is certainly not what we want. > > Signed-off-by: Ben Hutchings <bhutchings@solarflare.com> > --- > This should be safe to include in 2.6.31 but it's hardly critical. Applied to net-next-2.6, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/linux/mdio.h b/include/linux/mdio.h index cfdf1df..c779b49 100644 --- a/include/linux/mdio.h +++ b/include/linux/mdio.h @@ -304,7 +304,7 @@ static inline __u16 mdio_phy_id_devad(int phy_id) */ struct mdio_if_info { int prtad; - u32 __bitwise mmds; + u32 mmds; unsigned mode_support; struct net_device *dev;
I misunderstood the meaning of __bitwise. In practice it makes sparse warn about every use of mmds which is certainly not what we want. Signed-off-by: Ben Hutchings <bhutchings@solarflare.com> --- This should be safe to include in 2.6.31 but it's hardly critical. Ben. include/linux/mdio.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)