Patchwork libubox: new package

login
register
mail settings
Submitter Yegor Yefremov
Date Jan. 30, 2014, 11:11 a.m.
Message ID <1391080311-30640-1-git-send-email-yegorslists@googlemail.com>
Download mbox | patch
Permalink /patch/315309/
State Superseded
Headers show

Comments

Yegor Yefremov - Jan. 30, 2014, 11:11 a.m.
From: Yegor Yefremov <yegorslists@googlemail.com>

Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
 package/Config.in          |    1 +
 package/libubox/Config.in  |    6 ++++++
 package/libubox/libubox.mk |   13 +++++++++++++
 3 files changed, 20 insertions(+), 0 deletions(-)
 create mode 100644 package/libubox/Config.in
 create mode 100644 package/libubox/libubox.mk
Yann E. MORIN - March 3, 2014, 11:24 p.m.
Yegor, All,

Thanks for your contribution! Some comments below...

On 2014-01-30 12:11 +0100, yegorslists@googlemail.com spake thusly:
[--SNIP--]
> diff --git a/package/libubox/Config.in b/package/libubox/Config.in
> new file mode 100644
> index 0000000..c6efb33
> --- /dev/null
> +++ b/package/libubox/Config.in
> @@ -0,0 +1,6 @@
> +config BR2_PACKAGE_LIBUBOX
> +	bool "libubox"
> +	help
> +	  Small utility library for OpenWrt.

In what way would this be of interest to Buildroot?

Since this is "for OpenWRT", I fail to see the relevance to Buildroot.

> +	  http://nbd.name/gitweb.cgi?p=luci2/libubox.git;a=summary
> diff --git a/package/libubox/libubox.mk b/package/libubox/libubox.mk
> new file mode 100644
> index 0000000..ec8fbdb
> --- /dev/null
> +++ b/package/libubox/libubox.mk
> @@ -0,0 +1,13 @@
> +################################################################################
> +#
> +# libubox
> +#
> +################################################################################
> +
> +LIBUBOX_VERSION = bbd846ec2d72b2629758b69dc122ac0b0f2c3e4b
> +LIBUBOX_SITE = git://nbd.name/luci2/libubox.git
> +LIBUBOX_LICENSE = LGPLv2.1

This is not correct:
  - most of the files have a license header that do not reference the
    LGPLv2.1, but which I did not recognise  [0]
  - some have a BSD-3c license: avl.c
  - at least one file is GPLv2: md5.c

[0]
 * Copyright (C) 2012 Felix Fietkau <nbd@openwrt.org>
 *
 * Permission to use, copy, modify, and/or distribute this software for any
 * purpose with or without fee is hereby granted, provided that the above
 * copyright notice and this permission notice appear in all copies.
 *
 * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
 * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
 * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
 * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
 * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
 * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
 * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.

> +LIBUBOX_INSTALL_STAGING = YES
> +LIBUBOX_CONF_OPT = -DBUILD_LUA:BOOL=OFF

Maybe that could be made conditional on whether lua is enabled or not?

Regards,
Yann E. MORIN.
Yegor Yefremov - March 4, 2014, 6:59 a.m.
On Tue, Mar 4, 2014 at 12:24 AM, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> Yegor, All,
>
> Thanks for your contribution! Some comments below...
>
> On 2014-01-30 12:11 +0100, yegorslists@googlemail.com spake thusly:
> [--SNIP--]
>> diff --git a/package/libubox/Config.in b/package/libubox/Config.in
>> new file mode 100644
>> index 0000000..c6efb33
>> --- /dev/null
>> +++ b/package/libubox/Config.in
>> @@ -0,0 +1,6 @@
>> +config BR2_PACKAGE_LIBUBOX
>> +     bool "libubox"
>> +     help
>> +       Small utility library for OpenWrt.
>
> In what way would this be of interest to Buildroot?
>
> Since this is "for OpenWRT", I fail to see the relevance to Buildroot.

My goal is to port libuci to Buildroot as I have some software, that
I've written for OpenWRT and now would like to use in BR too. The
software uses /etc/config/* infrastructure to access its configuration
files via libuci.
libubox it a dependency of libuci.

I've also found libuci installation tutorials for Ubuntu :-)
http://www.wakoond.hu/2013/06/using-uci-on-ubuntu.html

>> +       http://nbd.name/gitweb.cgi?p=luci2/libubox.git;a=summary
>> diff --git a/package/libubox/libubox.mk b/package/libubox/libubox.mk
>> new file mode 100644
>> index 0000000..ec8fbdb
>> --- /dev/null
>> +++ b/package/libubox/libubox.mk
>> @@ -0,0 +1,13 @@
>> +################################################################################
>> +#
>> +# libubox
>> +#
>> +################################################################################
>> +
>> +LIBUBOX_VERSION = bbd846ec2d72b2629758b69dc122ac0b0f2c3e4b
>> +LIBUBOX_SITE = git://nbd.name/luci2/libubox.git
>> +LIBUBOX_LICENSE = LGPLv2.1
>
> This is not correct:
>   - most of the files have a license header that do not reference the
>     LGPLv2.1, but which I did not recognise  [0]
>   - some have a BSD-3c license: avl.c
>   - at least one file is GPLv2: md5.c

Hm. That's really odd. Should I omit license information for now?

> [0]
>  * Copyright (C) 2012 Felix Fietkau <nbd@openwrt.org>
>  *
>  * Permission to use, copy, modify, and/or distribute this software for any
>  * purpose with or without fee is hereby granted, provided that the above
>  * copyright notice and this permission notice appear in all copies.
>  *
>  * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
>  * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
>  * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
>  * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
>  * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
>  * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
>  * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
>
>> +LIBUBOX_INSTALL_STAGING = YES
>> +LIBUBOX_CONF_OPT = -DBUILD_LUA:BOOL=OFF
>
> Maybe that could be made conditional on whether lua is enabled or not?

I wanted to start with a simple configuration, as I don't need Lua
right now, but I'll incorporate this feature in the v2.

Yegor
Yann E. MORIN - March 4, 2014, 6:32 p.m.
On 2014-03-04 07:59 +0100, Yegor Yefremov spake thusly:
> On Tue, Mar 4, 2014 at 12:24 AM, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> > Yegor, All,
> >
> > Thanks for your contribution! Some comments below...
> >
> > On 2014-01-30 12:11 +0100, yegorslists@googlemail.com spake thusly:
> > [--SNIP--]
> >> diff --git a/package/libubox/Config.in b/package/libubox/Config.in
> >> new file mode 100644
> >> index 0000000..c6efb33
> >> --- /dev/null
> >> +++ b/package/libubox/Config.in
> >> @@ -0,0 +1,6 @@
> >> +config BR2_PACKAGE_LIBUBOX
> >> +     bool "libubox"
> >> +     help
> >> +       Small utility library for OpenWrt.
> >
> > In what way would this be of interest to Buildroot?
> >
> > Since this is "for OpenWRT", I fail to see the relevance to Buildroot.
> 
> My goal is to port libuci to Buildroot as I have some software, that
> I've written for OpenWRT and now would like to use in BR too. The
> software uses /etc/config/* infrastructure to access its configuration
> files via libuci.
> libubox it a dependency of libuci.

Ah, I see. Then, please say so in the help text (the one you provided is
not really interesting, as it does not say what libubox does).

> > This is not correct:
> >   - most of the files have a license header that do not reference the
> >     LGPLv2.1, but which I did not recognise  [0]

It might be MIT:
    http://spdx.org/licenses/MIT

> >   - some have a BSD-3c license: avl.c
> >   - at least one file is GPLv2: md5.c
> 
> Hm. That's really odd. Should I omit license information for now?

No, just state all of them:
    _LICENSES = GPLv2, BSD-3c, MIT

> >> +LIBUBOX_INSTALL_STAGING = YES
> >> +LIBUBOX_CONF_OPT = -DBUILD_LUA:BOOL=OFF
> >
> > Maybe that could be made conditional on whether lua is enabled or not?
> 
> I wanted to start with a simple configuration, as I don't need Lua
> right now, but I'll incorporate this feature in the v2.

OK, that's fine. If you don't use it, and so don't test it, there's no
reason to add it. If someone (or you, later) is interested in it, he'll
send a patch.

Regards,
Yann E. MORIN.
Yegor Yefremov - March 4, 2014, 7:24 p.m.
On Tue, Mar 4, 2014 at 7:32 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> On 2014-03-04 07:59 +0100, Yegor Yefremov spake thusly:
>> On Tue, Mar 4, 2014 at 12:24 AM, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
>> > Yegor, All,
>> >
>> > Thanks for your contribution! Some comments below...
>> >
>> > On 2014-01-30 12:11 +0100, yegorslists@googlemail.com spake thusly:
>> > [--SNIP--]
>> >> diff --git a/package/libubox/Config.in b/package/libubox/Config.in
>> >> new file mode 100644
>> >> index 0000000..c6efb33
>> >> --- /dev/null
>> >> +++ b/package/libubox/Config.in
>> >> @@ -0,0 +1,6 @@
>> >> +config BR2_PACKAGE_LIBUBOX
>> >> +     bool "libubox"
>> >> +     help
>> >> +       Small utility library for OpenWrt.
>> >
>> > In what way would this be of interest to Buildroot?
>> >
>> > Since this is "for OpenWRT", I fail to see the relevance to Buildroot.
>>
>> My goal is to port libuci to Buildroot as I have some software, that
>> I've written for OpenWRT and now would like to use in BR too. The
>> software uses /etc/config/* infrastructure to access its configuration
>> files via libuci.
>> libubox it a dependency of libuci.
>
> Ah, I see. Then, please say so in the help text (the one you provided is
> not really interesting, as it does not say what libubox does).

You're right. I'll post both patches for libubox and libuci. And who
knows, perhaps we would be able to run LuCI especially LuCI2 on BR.

>> > This is not correct:
>> >   - most of the files have a license header that do not reference the
>> >     LGPLv2.1, but which I did not recognise  [0]
>
> It might be MIT:
>     http://spdx.org/licenses/MIT
>
>> >   - some have a BSD-3c license: avl.c
>> >   - at least one file is GPLv2: md5.c
>>
>> Hm. That's really odd. Should I omit license information for now?
>
> No, just state all of them:
>     _LICENSES = GPLv2, BSD-3c, MIT
>
>> >> +LIBUBOX_INSTALL_STAGING = YES
>> >> +LIBUBOX_CONF_OPT = -DBUILD_LUA:BOOL=OFF
>> >
>> > Maybe that could be made conditional on whether lua is enabled or not?
>>
>> I wanted to start with a simple configuration, as I don't need Lua
>> right now, but I'll incorporate this feature in the v2.
>
> OK, that's fine. If you don't use it, and so don't test it, there's no
> reason to add it. If someone (or you, later) is interested in it, he'll
> send a patch.
>
> Regards,
> Yann E. MORIN.
>
> --
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'

Patch

diff --git a/package/Config.in b/package/Config.in
index 631d8b2..1d57e12 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -747,6 +747,7 @@  source "package/libsigc/Config.in"
 source "package/libsigsegv/Config.in"
 source "package/libtasn1/Config.in"
 source "package/libtpl/Config.in"
+source "package/libubox/Config.in"
 source "package/libunwind/Config.in"
 source "package/liburcu/Config.in"
 source "package/linux-pam/Config.in"
diff --git a/package/libubox/Config.in b/package/libubox/Config.in
new file mode 100644
index 0000000..c6efb33
--- /dev/null
+++ b/package/libubox/Config.in
@@ -0,0 +1,6 @@ 
+config BR2_PACKAGE_LIBUBOX
+	bool "libubox"
+	help
+	  Small utility library for OpenWrt.
+
+	  http://nbd.name/gitweb.cgi?p=luci2/libubox.git;a=summary
diff --git a/package/libubox/libubox.mk b/package/libubox/libubox.mk
new file mode 100644
index 0000000..ec8fbdb
--- /dev/null
+++ b/package/libubox/libubox.mk
@@ -0,0 +1,13 @@ 
+################################################################################
+#
+# libubox
+#
+################################################################################
+
+LIBUBOX_VERSION = bbd846ec2d72b2629758b69dc122ac0b0f2c3e4b
+LIBUBOX_SITE = git://nbd.name/luci2/libubox.git
+LIBUBOX_LICENSE = LGPLv2.1
+LIBUBOX_INSTALL_STAGING = YES
+LIBUBOX_CONF_OPT = -DBUILD_LUA:BOOL=OFF
+
+$(eval $(cmake-package))