Patchwork fix segfault of qemu-system-arm with PXA target

login
register
mail settings
Submitter Christoph Hellwig
Date Aug. 15, 2009, 9:17 p.m.
Message ID <20090815211758.GA23634@lst.de>
Download mbox | patch
Permalink /patch/31476/
State Superseded
Headers show

Comments

Christoph Hellwig - Aug. 15, 2009, 9:17 p.m.
qemu-system-arm (0.10.5) segfaults when invoked with a PXA machine target,      
e.g. -M tosa. The reason is fairly obvious:

[hch: forward ported from qemu-0.11 to current git HEAD]


Signed-off-by: Torsten Duwe <duwe@lst.de>
Signed-off-by: Christoph Hellwig <hch@lst.de>

Patch

Index: qemu/hw/zaurus.c
===================================================================
--- qemu.orig/hw/zaurus.c	2009-08-15 18:13:46.102699041 -0300
+++ qemu/hw/zaurus.c	2009-08-15 18:13:55.366663320 -0300
@@ -155,7 +155,7 @@  static CPUWriteMemoryFunc *scoop_writefn
 
 void scoop_gpio_set(void *opaque, int line, int level)
 {
-    ScoopInfo *s = (ScoopInfo *) s;
+    ScoopInfo *s = (ScoopInfo *) opaque;
 
     if (level)
         s->gpio_level |= (1 << line);