Patchwork [5/8] spi_mpc8xxx: Fix uninitialized variable

login
register
mail settings
Submitter Anton Vorontsov
Date Aug. 14, 2009, 10:25 p.m.
Message ID <20090814222555.GE14458@oksana.dev.rtsoft.ru>
Download mbox | patch
Permalink /patch/31444/
State Accepted
Commit 783058fd582a1d8afbbf1d4e9b7918614a4550ff
Delegated to: Kumar Gala
Headers show

Comments

Anton Vorontsov - Aug. 14, 2009, 10:25 p.m.
This patch fixes the following warning:

CC      drivers/spi/spi_mpc8xxx.o
  spi_mpc8xxx.c: In function 'of_mpc8xxx_spi_probe':
  spi_mpc8xxx.c:681: warning: 'ret' may be used uninitialized in this function

Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
 drivers/spi/spi_mpc8xxx.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Patch

diff --git a/drivers/spi/spi_mpc8xxx.c b/drivers/spi/spi_mpc8xxx.c
index 0fd0ec4..518671b 100644
--- a/drivers/spi/spi_mpc8xxx.c
+++ b/drivers/spi/spi_mpc8xxx.c
@@ -709,6 +709,7 @@  static int of_mpc8xxx_spi_get_chipselects(struct device *dev)
 		gpio = of_get_gpio_flags(np, i, &flags);
 		if (!gpio_is_valid(gpio)) {
 			dev_err(dev, "invalid gpio #%d: %d\n", i, gpio);
+			ret = gpio;
 			goto err_loop;
 		}