diff mbox

[2/2] net: stmmac: Log MAC address only once

Message ID 1390747844-25060-2-git-send-email-hdegoede@redhat.com
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Hans de Goede Jan. 26, 2014, 2:50 p.m. UTC
Logging the MAC address on every if-up, is not really useful, and annoying when
there is no cable inserted and NetworkManager tries the ifup every 50 seconds.

Also change the log level from warning to info, as that is what it is.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

David Miller Jan. 27, 2014, 6:43 a.m. UTC | #1
From: Hans de Goede <hdegoede@redhat.com>
Date: Sun, 26 Jan 2014 15:50:44 +0100

> Logging the MAC address on every if-up, is not really useful, and annoying when
> there is no cable inserted and NetworkManager tries the ifup every 50 seconds.
> 
> Also change the log level from warning to info, as that is what it is.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 838d0b7..920b3c6 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -1523,9 +1523,9 @@  static void stmmac_check_ether_addr(struct stmmac_priv *priv)
 					     priv->dev->dev_addr, 0);
 		if (!is_valid_ether_addr(priv->dev->dev_addr))
 			eth_hw_addr_random(priv->dev);
+		pr_info("%s: device MAC address %pM\n", priv->dev->name,
+			priv->dev->dev_addr);
 	}
-	pr_warn("%s: device MAC address %pM\n", priv->dev->name,
-		priv->dev->dev_addr);
 }
 
 /**