diff mbox

[U-Boot,1/7] tools/image-host: fix sign-images bug

Message ID 1390632269-8971-2-git-send-email-hs@denx.de
State Superseded
Delegated to: Tom Rini
Headers show

Commit Message

Heiko Schocher Jan. 25, 2014, 6:44 a.m. UTC 
property "sign-images" is never found, fix this.

Signed-off-by: Heiko Schocher <hs@denx.de>
Cc: Simon Glass <sjg@chromium.org>
---
 tools/image-host.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Simon Glass Jan. 26, 2014, 9:05 p.m. UTC | #1 
Hi Heiko,

On 24 January 2014 23:44, Heiko Schocher <hs@denx.de> wrote:
> property "sign-images" is never found, fix this.
>
> Signed-off-by: Heiko Schocher <hs@denx.de>
> Cc: Simon Glass <sjg@chromium.org>
> ---
>  tools/image-host.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/image-host.c b/tools/image-host.c
> index 0d5c88c..8e185ec 100644
> --- a/tools/image-host.c
> +++ b/tools/image-host.c
> @@ -403,7 +403,7 @@ static int fit_config_get_hash_list(void *fit, int conf_noffset,
>                 goto err_mem;
>
>         /* Get a list of images that we intend to sign */
> -       prop = fit_config_get_image_list(fit, conf_noffset, &len,
> +       prop = fit_config_get_image_list(fit, sig_offset, &len,
>                                         &allow_missing);

Acked-by: Simon Glass <sjg@chromium.org>

Unfortunately I did not add a test for this.

>         if (!prop)
>                 return 0;
> --
> 1.8.3.1
>

Regards,
Simon
diff mbox

Patch

diff --git a/tools/image-host.c b/tools/image-host.c
index 0d5c88c..8e185ec 100644
--- a/tools/image-host.c
+++ b/tools/image-host.c
@@ -403,7 +403,7 @@  static int fit_config_get_hash_list(void *fit, int conf_noffset,
 		goto err_mem;
 
 	/* Get a list of images that we intend to sign */
-	prop = fit_config_get_image_list(fit, conf_noffset, &len,
+	prop = fit_config_get_image_list(fit, sig_offset, &len,
 					&allow_missing);
 	if (!prop)
 		return 0;