Patchwork Re: save/restore broken?

login
register
mail settings
Submitter Juan Quintela
Date Aug. 13, 2009, 7:23 p.m.
Message ID <m3fxbvecx5.fsf@neno.mitica>
Download mbox | patch
Permalink /patch/31351/
State Superseded
Headers show

Comments

Juan Quintela - Aug. 13, 2009, 7:23 p.m.
Luiz Capitulino <lcapitulino@redhat.com> wrote:
> On Tue, 11 Aug 2009 18:39:47 +0200
> Paolo Bonzini <bonzini@gnu.org> wrote:
>
>> Hi all,
>> 
>> if I try to save and restore an image using current qemu and current 
>> libvirt, the load fails.
>
>  Yes, it's broken. I'm unable to loadvm and to migrate.
>
>  According to git bisect the problem was introduced by:
>
> """
> commit 93c8cfd9e67a62711b86f4c93747566885eb7928
> Author: Gleb Natapov <gleb@redhat.com>
> Date:   Sun Aug 2 11:36:47 2009 +0300
>
>     make windows notice media change
> """
>
>  Indeed, reverting this fixes it for me.
>
>  When I try to loadvm I get this error:
>
> """
> Unknown savevm section type 255
> Error -22 while loading VM state
> """
>
>  The migration symptoms are different. Sometimes it
> prints the same message, sometimes it kind of works
> but gets strange behaviors.

This patch fixes it for me, could you take a look if it also fixes things for you?

Thanks.

From 1322dfad92766a402c341071b0d55be6e510ebb1 Mon Sep 17 00:00:00 2001
From: Juan Quintela <quintela@redhat.com>
Date: Thu, 13 Aug 2009 21:07:05 +0200
Subject: [PATCH] Fix migration, if we read a field, it is better if we wrote it first


Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 hw/ide.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Patch

diff --git a/hw/ide.c b/hw/ide.c
index bebda7c..1e38ae3 100644
--- a/hw/ide.c
+++ b/hw/ide.c
@@ -2888,6 +2888,7 @@  static void ide_save(QEMUFile* f, IDEState *s)

     qemu_put_8s(f, &s->sense_key);
     qemu_put_8s(f, &s->asc);
+    qemu_put_8s(f, &s->cdrom_changed);
     /* XXX: if a transfer is pending, we do not save it yet */
 }