From patchwork Thu Aug 13 18:59:52 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anthony Liguori X-Patchwork-Id: 31348 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by bilbo.ozlabs.org (Postfix) with ESMTPS id 95A97B6F2B for ; Fri, 14 Aug 2009 05:00:34 +1000 (EST) Received: from localhost ([127.0.0.1]:36374 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MbfXK-0004eH-RD for incoming@patchwork.ozlabs.org; Thu, 13 Aug 2009 15:00:30 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MbfWr-0004dA-5C for qemu-devel@nongnu.org; Thu, 13 Aug 2009 15:00:01 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MbfWm-0004cS-L0 for qemu-devel@nongnu.org; Thu, 13 Aug 2009 15:00:00 -0400 Received: from [199.232.76.173] (port=58395 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MbfWm-0004cP-GT for qemu-devel@nongnu.org; Thu, 13 Aug 2009 14:59:56 -0400 Received: from mail-qy0-f174.google.com ([209.85.221.174]:45547) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MbfWl-00066r-Vi for qemu-devel@nongnu.org; Thu, 13 Aug 2009 14:59:56 -0400 Received: by qyk4 with SMTP id 4so769869qyk.4 for ; Thu, 13 Aug 2009 11:59:54 -0700 (PDT) Received: by 10.224.103.70 with SMTP id j6mr1641017qao.208.1250189994824; Thu, 13 Aug 2009 11:59:54 -0700 (PDT) Received: from squirrel.codemonkey.ws ([24.174.33.212]) by mx.google.com with ESMTPS id 5sm1363234qwg.50.2009.08.13.11.59.53 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 13 Aug 2009 11:59:54 -0700 (PDT) Message-ID: <4A8462A8.1020206@codemonkey.ws> Date: Thu, 13 Aug 2009 13:59:52 -0500 From: Anthony Liguori User-Agent: Thunderbird 2.0.0.21 (X11/20090320) MIME-Version: 1.0 To: Luiz Capitulino Subject: Re: [Qemu-devel] save/restore broken? References: <20090813154827.409ed832@doriath> In-Reply-To: <20090813154827.409ed832@doriath> X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Cc: Paolo Bonzini , qemu-devel@nongnu.org, gleb@redhat.com X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Luiz Capitulino wrote: > On Tue, 11 Aug 2009 18:39:47 +0200 > Paolo Bonzini wrote: > > >> Hi all, >> >> if I try to save and restore an image using current qemu and current >> libvirt, the load fails. >> > > Yes, it's broken. I'm unable to loadvm and to migrate. > > According to git bisect the problem was introduced by: This should fix it. Regards, Anthony Liguori commit a536948b3805a311f274b119c5202fdc86504cf3 Author: Anthony Liguori Date: Thu Aug 13 13:58:21 2009 -0500 Fix migration for ide devices commit 93c8cfd9e67a62711b86f4c93747566885eb7928 Author: Gleb Natapov Date: Sun Aug 2 11:36:47 2009 +0300 make windows notice media change Broke save/restore by loading a new field but not saving it. Signed-off-by: Anthony Liguori diff --git a/hw/ide.c b/hw/ide.c index bebda7c..1e38ae3 100644 --- a/hw/ide.c +++ b/hw/ide.c @@ -2888,6 +2888,7 @@ static void ide_save(QEMUFile* f, IDEState *s) qemu_put_8s(f, &s->sense_key); qemu_put_8s(f, &s->asc); + qemu_put_8s(f, &s->cdrom_changed); /* XXX: if a transfer is pending, we do not save it yet */ }