| Message ID | 52E0CBD4.5090306@huawei.com |
|---|---|
| State | New |
| Headers | show |
Am 23.01.2014 um 08:59 hat Zhang Min geschrieben: > > In the function mirror_iteration() -> qemu_iovec_init(), > it allocates memory for op->qiov.iov, when the write request calls back, > but in the function mirror_iteration_done(), it only frees the op, > not free the op->qiov.iov, so this causes memory leak. > > It should use qemu_iovec_destroy() to free op->qiov. > > Signed-off-by: Zhang Min <rudy.zhangmin@huawei.com> Thanks, applied to the block branch. Kevin
diff --git a/block/mirror.c b/block/mirror.c index 2932bab..05758e5 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -96,6 +96,7 @@ static void mirror_iteration_done(MirrorOp *op, int ret) bitmap_set(s->cow_bitmap, chunk_num, nb_chunks); } + qemu_iovec_destroy(&op->qiov); g_slice_free(MirrorOp, op); qemu_coroutine_enter(s->common.co, NULL); }
In the function mirror_iteration() -> qemu_iovec_init(), it allocates memory for op->qiov.iov, when the write request calls back, but in the function mirror_iteration_done(), it only frees the op, not free the op->qiov.iov, so this causes memory leak. It should use qemu_iovec_destroy() to free op->qiov. Signed-off-by: Zhang Min <rudy.zhangmin@huawei.com> --- block/mirror.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)