| Message ID | 1390387435-23918-1-git-send-email-jiri@resnulli.us |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Jiri Pirko <jiri@resnulli.us> Date: Wed, 22 Jan 2014 11:43:55 +0100 > Not used anymore, and never should be. > > Signed-off-by: Jiri Pirko <jiri@resnulli.us> First of all your Subject doesn't match the patch, the subject mentions IFLA_SLAVES whereas the patch deletes IFLA_BOND_SLAVE. Secondly, you can't remove this, otherwise the next IFLA_* value added here will reuse that old number potentially breaking userland apps. I'm not applying this, sorry. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Thu, Jan 23, 2014 at 09:47:16PM CET, davem@davemloft.net wrote: >From: Jiri Pirko <jiri@resnulli.us> >Date: Wed, 22 Jan 2014 11:43:55 +0100 > >> Not used anymore, and never should be. >> >> Signed-off-by: Jiri Pirko <jiri@resnulli.us> > >First of all your Subject doesn't match the patch, the subject mentions >IFLA_SLAVES whereas the patch deletes IFLA_BOND_SLAVE. Yep, sorry, IFLA_SLAVE was the original name, which I removed. Should I repost? > >Secondly, you can't remove this, otherwise the next IFLA_* value added >here will reuse that old number potentially breaking userland apps. This has been in net-next tree for 3 days. It was a mistake, I think there is very legit to remove this now, isn't it? > >I'm not applying this, sorry. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Jiri Pirko <jiri@resnulli.us> Date: Thu, 23 Jan 2014 22:33:45 +0100 > Thu, Jan 23, 2014 at 09:47:16PM CET, davem@davemloft.net wrote: >>From: Jiri Pirko <jiri@resnulli.us> >>Date: Wed, 22 Jan 2014 11:43:55 +0100 >> >>Secondly, you can't remove this, otherwise the next IFLA_* value added >>here will reuse that old number potentially breaking userland apps. > > This has been in net-next tree for 3 days. It was a mistake, I think > there is very legit to remove this now, isn't it? Fair enough, please resend with fixed Subj. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h index b8fb352..ed7b2f8 100644 --- a/include/uapi/linux/if_link.h +++ b/include/uapi/linux/if_link.h @@ -144,7 +144,6 @@ enum { IFLA_NUM_RX_QUEUES, IFLA_CARRIER, IFLA_PHYS_PORT_ID, - IFLA_BOND_SLAVE, __IFLA_MAX };
Not used anymore, and never should be. Signed-off-by: Jiri Pirko <jiri@resnulli.us> --- include/uapi/linux/if_link.h | 1 - 1 file changed, 1 deletion(-)