Message ID | 4A840B4E.7050801@redhat.com |
---|---|
State | Superseded |
Headers | show |
Gerd Hoffmann wrote: > On 08/13/09 11:00, Avi Kivity wrote: >>> Where were the irq routing trouble fixes in qemu-kvm? Was it fixes in >>> the BIOS? >> >> I think so, but not 100% sure. > > Lets start with the attached fix. bochs build system doesn't compile > the dsdt. Which implies that the patches in pc-bios/bios-pq/ which > change the dsdt have no effect at all. When I rebuild the bios locally, I manually change this in the generated Makefile. But I'm going to merge a git submodule for bochs bios today into the tree. The Makefile in that tree already has this bit removed. Regards, Anthony Liguori
On 08/13/09 15:15, Anthony Liguori wrote: > Gerd Hoffmann wrote: >> On 08/13/09 11:00, Avi Kivity wrote: >>>> Where were the irq routing trouble fixes in qemu-kvm? Was it fixes in >>>> the BIOS? >>> >>> I think so, but not 100% sure. >> >> Lets start with the attached fix. bochs build system doesn't compile >> the dsdt. Which implies that the patches in pc-bios/bios-pq/ which >> change the dsdt have no effect at all. > > When I rebuild the bios locally, I manually change this in the generated > Makefile. Hmm, strange. With the patch applied on top of the others I get a working bios when building according to the instructions in pc-bios/README. The prebuild bios.bin doesn't work for me though. cheers, Gerd
diff --git a/bios/Makefile.in b/bios/Makefile.in index 28ada75..7d8a65a 100644 --- a/bios/Makefile.in +++ b/bios/Makefile.in @@ -103,13 +103,11 @@ rombios32.out: rombios32start.o rombios32.o rombios32.ld rombios32.o: rombios32.c acpi-dsdt.hex $(GCC32) -O2 -Wall -c -o $@ $< -ifeq ("1", "0") acpi-dsdt.hex: acpi-dsdt.dsl cpp -P $< $<.i iasl -tc -p $@ $<.i rm $<.i sed -i -e's/^unsigned/const unsigned/' $@ -endif rombios32start.o: rombios32start.S $(GCC32) -c -o $@ $<