diff mbox

build: Fix installation of target-dependent files

Message ID 20140120112153.5685.30949.stgit@fimbulvetr.bsc.es
State New
Headers show

Commit Message

Lluís Vilanova Jan. 20, 2014, 11:21 a.m. UTC
Pass all the relevant sub-directory make variables.

Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
---
 Makefile |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Lluís Vilanova Feb. 10, 2014, 8 p.m. UTC | #1
Lluís Vilanova writes:

> Pass all the relevant sub-directory make variables.

Ping.

Thanks,
  Lluis


> Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
> ---
>  Makefile |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/Makefile b/Makefile
> index bdff4e4..02ae76d 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -366,7 +366,7 @@ endif
>  		$(INSTALL_DATA) $(SRC_PATH)/pc-bios/keymaps/$$x "$(DESTDIR)$(qemu_datadir)/keymaps"; \
>  	done
>  	for d in $(TARGET_DIRS); do \
> -	$(MAKE) -C $$d $@ || exit 1 ; \
> +	$(MAKE) $(SUBDIR_MAKEFLAGS) TARGET_DIR=$$d/ -C $$d $@ || exit 1 ; \
>          done
 
>  # various test targets
Lluís Vilanova March 7, 2014, 1:19 a.m. UTC | #2
Lluís Vilanova writes:

> Lluís Vilanova writes:
>> Pass all the relevant sub-directory make variables.

> Ping.

Ping^2


> Thanks,
>   Lluis


>> Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
>> ---
>> Makefile |    2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)

>> diff --git a/Makefile b/Makefile
>> index bdff4e4..02ae76d 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -366,7 +366,7 @@ endif
>> $(INSTALL_DATA) $(SRC_PATH)/pc-bios/keymaps/$$x "$(DESTDIR)$(qemu_datadir)/keymaps"; \
>> done
>> for d in $(TARGET_DIRS); do \
>> -	$(MAKE) -C $$d $@ || exit 1 ; \
>> +	$(MAKE) $(SUBDIR_MAKEFLAGS) TARGET_DIR=$$d/ -C $$d $@ || exit 1 ; \
>> done
 
>> # various test targets
Paolo Bonzini March 7, 2014, 7:32 a.m. UTC | #3
Il 07/03/2014 02:19, Lluís Vilanova ha scritto:
> Lluís Vilanova writes:
>
>> Lluís Vilanova writes:
>>> Pass all the relevant sub-directory make variables.
>
>> Ping.
>
> Ping^2
>
>
>> Thanks,
>>   Lluis
>
>
>>> Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
>>> ---
>>> Makefile |    2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>>> diff --git a/Makefile b/Makefile
>>> index bdff4e4..02ae76d 100644
>>> --- a/Makefile
>>> +++ b/Makefile
>>> @@ -366,7 +366,7 @@ endif
>>> $(INSTALL_DATA) $(SRC_PATH)/pc-bios/keymaps/$$x "$(DESTDIR)$(qemu_datadir)/keymaps"; \
>>> done
>>> for d in $(TARGET_DIRS); do \
>>> -	$(MAKE) -C $$d $@ || exit 1 ; \
>>> +	$(MAKE) $(SUBDIR_MAKEFLAGS) TARGET_DIR=$$d/ -C $$d $@ || exit 1 ; \
>>> done
>
>>> # various test targets
>
>

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

Paolo
Peter Maydell March 8, 2014, 12:17 p.m. UTC | #4
On 20 January 2014 11:21, Lluís Vilanova <vilanova@ac.upc.edu> wrote:
> Pass all the relevant sub-directory make variables.
>
> Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
> ---
>  Makefile |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master as a build fix of sorts.

thanks
-- PMM
diff mbox

Patch

diff --git a/Makefile b/Makefile
index bdff4e4..02ae76d 100644
--- a/Makefile
+++ b/Makefile
@@ -366,7 +366,7 @@  endif
 		$(INSTALL_DATA) $(SRC_PATH)/pc-bios/keymaps/$$x "$(DESTDIR)$(qemu_datadir)/keymaps"; \
 	done
 	for d in $(TARGET_DIRS); do \
-	$(MAKE) -C $$d $@ || exit 1 ; \
+	$(MAKE) $(SUBDIR_MAKEFLAGS) TARGET_DIR=$$d/ -C $$d $@ || exit 1 ; \
         done
 
 # various test targets