diff mbox

[03/10] transmission: use <PKG>_INSTALL_INIT_SYSV infra instead of custom hook

Message ID 1390073027-14239-4-git-send-email-s.martin49@gmail.com
State Accepted
Headers show

Commit Message

Samuel Martin Jan. 18, 2014, 7:23 p.m. UTC 
Signed-off-by: Samuel Martin <s.martin49@gmail.com>
---
 package/transmission/transmission.mk | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Yann E. MORIN Jan. 18, 2014, 7:52 p.m. UTC | #1 
Samuel, All,

On 2014-01-18 20:23 +0100, Samuel Martin spake thusly:
> Signed-off-by: Samuel Martin <s.martin49@gmail.com>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.
Peter Korsgaard Jan. 19, 2014, 8:19 p.m. UTC | #2 
>>>>> "Samuel" == Samuel Martin <s.martin49@gmail.com> writes:

 > Signed-off-by: Samuel Martin <s.martin49@gmail.com>
 > ---
 >  package/transmission/transmission.mk | 3 +--
 >  1 file changed, 1 insertion(+), 2 deletions(-)

 > diff --git a/package/transmission/transmission.mk b/package/transmission/transmission.mk
 > index 3ced558..e52c7be 100644
 > --- a/package/transmission/transmission.mk
 > +++ b/package/transmission/transmission.mk
 > @@ -19,7 +19,7 @@ TRANSMISSION_CONF_OPT = \
 >  	--disable-libnotify \
 >  	--enable-lightweight
 
 > -define TRANSMISSION_INIT_SCRIPT_INSTALL
 > +define TRANSMISSION_INSTALL_INIT_SYSV
 >  	[ -f $(TARGET_DIR)/etc/init.d/S92transmission ] || \
 >  		$(INSTALL) -m 0755 -D package/transmission/S92transmission \
 >  			$(TARGET_DIR)/etc/init.d/S92transmission
 > @@ -39,7 +39,6 @@ endif
 
 >  ifeq ($(BR2_PACKAGE_TRANSMISSION_DAEMON),y)
 >  	TRANSMISSION_CONF_OPT += --enable-daemon
 > -	TRANSMISSION_POST_INSTALL_TARGET_HOOKS += TRANSMISSION_INIT_SCRIPT_INSTALL

With this change we're installing the init script even if _DAEMON isn't
enabled, so I've fixed it by moving TRANSMISSION_INSTALL_INIT_SYSV here.

Committed with that change, thanks.

 >  else
 >  	TRANSMISSION_CONF_OPT += --disable-daemon
 >  endif
 > -- 
 > 1.8.5.3

 > _______________________________________________
 > buildroot mailing list
 > buildroot@busybox.net
 > http://lists.busybox.net/mailman/listinfo/buildroot
diff mbox

Patch

diff --git a/package/transmission/transmission.mk b/package/transmission/transmission.mk
index 3ced558..e52c7be 100644
--- a/package/transmission/transmission.mk
+++ b/package/transmission/transmission.mk
@@ -19,7 +19,7 @@  TRANSMISSION_CONF_OPT = \
 	--disable-libnotify \
 	--enable-lightweight
 
-define TRANSMISSION_INIT_SCRIPT_INSTALL
+define TRANSMISSION_INSTALL_INIT_SYSV
 	[ -f $(TARGET_DIR)/etc/init.d/S92transmission ] || \
 		$(INSTALL) -m 0755 -D package/transmission/S92transmission \
 			$(TARGET_DIR)/etc/init.d/S92transmission
@@ -39,7 +39,6 @@  endif
 
 ifeq ($(BR2_PACKAGE_TRANSMISSION_DAEMON),y)
 	TRANSMISSION_CONF_OPT += --enable-daemon
-	TRANSMISSION_POST_INSTALL_TARGET_HOOKS += TRANSMISSION_INIT_SCRIPT_INSTALL
 else
 	TRANSMISSION_CONF_OPT += --disable-daemon
 endif