From patchwork Sat Jan 18 02:53:34 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 312259 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id E744A2C009A for ; Sat, 18 Jan 2014 13:53:49 +1100 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:subject:message-id:reply-to:mime-version:content-type; q=dns; s=default; b=fqvVxvP6MmV8IyFQmymBWHvFgmt9ZZys6XNjdF/Jpe3 opCJ//n/5elqhMp74m4Sz3bJX6P0tpYl/HJ8hcNvtO7rTvcn8A1dKjg23Em7RWRh jHMpjcZZHzF88LBEk+k07a94ir7zOrA56Snea5nKT/7XzqocZcXHqmnemLLiQzYo = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:subject:message-id:reply-to:mime-version:content-type; s=default; bh=1vxuBNBW8yWzkMgbip+49cPbcww=; b=A5tMME+z9q/VlcUDH Isuo8Tr6mh1kyZOdKvbIuDIUX4ntLMUdhkRCsJxRb+t2rY0DrvLPfQV9wdV7posV ffsBwr+8ZikL0grMynlPOXn+AoM92i7wNBvF7ySdCDW9ykg4XhlfFqMS3tdEL/PQ V5xO9XL+enPLYB59NsbOswtqwY= Received: (qmail 10059 invoked by alias); 18 Jan 2014 02:53:42 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 10043 invoked by uid 89); 18 Jan 2014 02:53:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL, BAYES_00, NO_DNS_FOR_FROM, RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mga03.intel.com Received: from mga03.intel.com (HELO mga03.intel.com) (143.182.124.21) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 18 Jan 2014 02:53:39 +0000 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by azsmga101.ch.intel.com with ESMTP; 17 Jan 2014 18:53:37 -0800 X-ExtLoop1: 1 Received: from gnu-4.sc.intel.com ([172.25.70.54]) by fmsmga001.fm.intel.com with ESMTP; 17 Jan 2014 18:53:35 -0800 Received: by gnu-4.sc.intel.com (Postfix, from userid 1000) id 842E020694; Fri, 17 Jan 2014 18:53:34 -0800 (PST) Date: Fri, 17 Jan 2014 18:53:34 -0800 From: "H.J. Lu" To: gcc-patches@gcc.gnu.org Subject: [committed] PATCH: Fix a comment typo in ix86_split_lea_for_addr Message-ID: <20140118025334.GA680@lucon.org> Reply-To: "H.J. Lu" MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Hi, I checked in this patch as an obvious fix to correct a comment typo in ix86_split_lea_for_addr. The line below the comments is gcc_assert (regno2 != regno0); There is no way for r1 = r1 + C * r1. It should be r1 = r1 + C * r2. H.J. Index: ChangeLog =================================================================== --- ChangeLog (revision 206744) +++ ChangeLog (working copy) @@ -1,3 +1,8 @@ +2014-01-17 H.J. Lu + + * config/i386/i386.c (ix86_split_lea_for_addr): Fix a comment + typo. + 2014-01-17 John David Anglin * config/pa/pa.c (pa_attr_length_indirect_call): Don't output a short Index: config/i386/i386.c =================================================================== --- config/i386/i386.c (revision 206744) +++ config/i386/i386.c (working copy) @@ -18309,7 +18309,7 @@ ix86_split_lea_for_addr (rtx insn, rtx o /* Case r1 = r1 + ... */ if (regno1 == regno0) { - /* If we have a case r1 = r1 + C * r1 then we + /* If we have a case r1 = r1 + C * r2 then we should use multiplication which is very expensive. Assume cost model is wrong if we have such case here. */