Patchwork [1/7] atapi: fix up a few comments

login
register
mail settings
Submitter Ian Jackson
Date Aug. 11, 2009, 3:35 p.m.
Message ID <E1MbHTh-0007l0-4s@mariner.uk.xensource.com>
Download mbox | patch
Permalink /patch/31225/
State Superseded
Headers show

Comments

Ian Jackson - Aug. 11, 2009, 3:35 p.m.
Signed-off-by: Alexandre Bique <alexandre.bique@citrix.com>
---
 hw/ide.c |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

Patch

diff --git a/hw/ide.c b/hw/ide.c
index bebda7c..675a06d 100644
--- a/hw/ide.c
+++ b/hw/ide.c
@@ -1682,9 +1682,9 @@  static void ide_atapi_cmd(IDEState *s)
             switch(action) {
             case 0: /* current values */
                 switch(code) {
-                case 0x01: /* error recovery */
+                case 0x01: /* read write error recovery parameters */
                     cpu_to_ube16(&buf[0], 16 + 6);
-                    buf[2] = 0x70;
+                    buf[2] = 0x70; /* Obsolete: medium type code */
                     buf[3] = 0;
                     buf[4] = 0;
                     buf[5] = 0;
@@ -1701,17 +1701,17 @@  static void ide_atapi_cmd(IDEState *s)
                     buf[15] = 0x00;
                     ide_atapi_cmd_reply(s, 16, max_len);
                     break;
-                case 0x2a:
+                case 0x2a: /* CD/DVD capabilities & mechanical status */
                     cpu_to_ube16(&buf[0], 28 + 6);
-                    buf[2] = 0x70;
+                    buf[2] = 0x70; /* Obsolete: medium type code */
                     buf[3] = 0;
                     buf[4] = 0;
                     buf[5] = 0;
                     buf[6] = 0;
                     buf[7] = 0;
 
-                    buf[8] = 0x2a;
-                    buf[9] = 0x12;
+                    buf[8] = 0x2a; /* page code */
+                    buf[9] = 0x12; /* page length */
                     buf[10] = 0x00;
                     buf[11] = 0x00;