From patchwork Fri Jan 17 22:43:04 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Lance Taylor X-Patchwork-Id: 312212 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 6E7C92C009A for ; Sat, 18 Jan 2014 09:43:18 +1100 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:date:message-id:mime-version:content-type; q=dns; s= default; b=Z2QuP0WPp1e3M3ijMGzlm0Bej+NJ30uG342wRZVAvGKLqDtb15tSy FHEXCu98IZ6EjaOt7nhzPEr0jL5JnQ7ahzMLSWpo7Dy98Q7mPD1N7d+2MiQgHD+W PLHuJnoqcl4FjyIhpH/ENTw33sF/5x3uag5tgT9KnAe0+O5hiXNapU= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:date:message-id:mime-version:content-type; s= default; bh=oUpMV3zK6lRRNmQAgBn50GJYzP0=; b=wvf1+QWqmWatBodfWicZ K/3ACtCER0+7tHff27QKFOzgS3XXdgx/iyOTZn+Xh8xUWxGum4oc77M1N9krf5WC ym0zVubGy4F8wrjIPUFgcJMq3UhLt0jPiUPmhO1Cva6e9fh4g3RqanSWLLiFnagE dKBUr334hEuQqMzce4z+RKo= Received: (qmail 6947 invoked by alias); 17 Jan 2014 22:43:11 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 6918 invoked by uid 89); 17 Jan 2014 22:43:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, RP_MATCHES_RCVD, SPF_PASS, T_TVD_MIME_NO_HEADERS autolearn=ham version=3.3.2 X-HELO: mail-yh0-f42.google.com Received: from mail-yh0-f42.google.com (HELO mail-yh0-f42.google.com) (209.85.213.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 17 Jan 2014 22:43:10 +0000 Received: by mail-yh0-f42.google.com with SMTP id z12so1318283yhz.29 for ; Fri, 17 Jan 2014 14:43:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version:content-type; bh=3UrGDjA1kiJZeid//hauRNp3QLWxjuKEae9lLg2yz98=; b=lxBSFgmTfB7rSGth4hFFjCGaBImL6Xgv/4VlkpAJSqD+nWoYZc7zVyDYiEwuYcIrCs 9umyfwrKv9fEN06KatU/5KUfV4QOCasSvxNEAMsHj7XPUwL9VbFQIZb0obtcDk/ZOmuf WqdAza3I4j2iTna7k4l9Cn7/nDnyGn3mNW43bprpWOkk4jtVS1vqfFvGXwcK1CmQVYaa 0+fPSptdZbOi/pfvCUs3/7wb5osC62qPQgxeMJjRnddIc68mVx/3a9aGudE4o/WSbXhF St9ZqmKHVjMO3HZe9zsOBwZGjyWb6UzMnemEPgRExzROmr0gz2hQY2JuNZAbrzqbm2ul mxig== X-Gm-Message-State: ALoCoQm+ztu+5vqM6OYSNfNhT1E0No5GIg3DInyHeFp3OJ12oGGHGj6nykGVnHdv3ppVb1lUB486Caeb3GicMQHTixnFBgRr5yI6VjDYVgbEgZlctqe8x6CIKqUdeBW0suJEtjMlG3mNLRdfxVXV21pMFh2Nrt2Chonhn+qKATsP5ybuUbOZsmLO2yefGow3xymgvzhrSaFFMPmKLp0tsTNNhpifG/JHiw== X-Received: by 10.236.63.135 with SMTP id a7mr332942yhd.84.1389998588150; Fri, 17 Jan 2014 14:43:08 -0800 (PST) Received: from iant-glaptop.roam.corp.google.com.google.com ([2620:0:1000:3204:c852:5d10:f07a:f251]) by mx.google.com with ESMTPSA id d7sm20712192yhd.24.2014.01.17.14.43.06 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 17 Jan 2014 14:43:07 -0800 (PST) From: Ian Lance Taylor To: gcc-patches@gcc.gnu.org, gofrontend-dev@googlegroups.com Subject: libgo patch committed: Align variable on 8-byte boundary Date: Fri, 17 Jan 2014 14:43:04 -0800 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 X-IsSubscribed: yes This patch to libgo aligns the variable work in mgc0.c on an 8-byte boundary. The code expects that to be the case, and complains if it is not aligned. It would already be the case on a 64-bit system, but not necessarily on a 32-bit system. I haven't been able to recreate PR 59866, but I think this will fix it. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to 4.8 branch and mainline. Ian diff -r f1ef2f3189a2 libgo/runtime/mgc0.c --- a/libgo/runtime/mgc0.c Thu Jan 16 20:32:18 2014 -0800 +++ b/libgo/runtime/mgc0.c Fri Jan 17 14:36:08 2014 -0800 @@ -180,7 +180,7 @@ Obj *roots; uint32 nroot; uint32 rootcap; -} work; +} work __attribute__((aligned(8))); enum { GC_DEFAULT_PTR = GC_NUM_INSTR,