From patchwork Fri Jan 17 18:11:42 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Ellcey X-Patchwork-Id: 312162 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 0D9B22C0099 for ; Sat, 18 Jan 2014 05:12:28 +1100 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:subject:from:to:cc:date:in-reply-to:references :content-type:content-transfer-encoding:mime-version; q=dns; s= default; b=wekAZb7EUD+xLYiaVQenja3FoYKYgUwNSh8/lYSeoyWvEMr7wDkdk BiAZqhMkmY5FvXv9+AVCqif7sCEPeaumYs1ugFxFPMa7nUjQmc3ZNxmXqILpdqb9 KPHFzu/JAveKpT6GWG5MMZKnqZ7KbWKi/JhYoCMUeithGJGuhPVTeY= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:subject:from:to:cc:date:in-reply-to:references :content-type:content-transfer-encoding:mime-version; s=default; bh=dW+PRxj08ELJVz76mi2JIJlVfRc=; b=vGcKm6CHDZcRR9bBkD3Bwy13YMjx d+fjOjLzJUhmnPf+kF67UX/0p7eQEmsw2cIyQNFATR08PHxb4AWZeh3lUsXchKtJ tnfw7YusEpF0nCyEj1FJmVaUB8RKK5/LILswhv9eywXZaiP6cgUdyqd2rUYLBCBH PzFQ5Ts9+tI9kn8= Received: (qmail 21484 invoked by alias); 17 Jan 2014 18:12:19 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 21472 invoked by uid 89); 17 Jan 2014 18:12:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: multi.imgtec.com Received: from multi.imgtec.com (HELO multi.imgtec.com) (194.200.65.239) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 17 Jan 2014 18:12:16 +0000 Message-ID: <1389982302.3022.49.camel@ubuntu-sellcey> Subject: Re: [Patch, cilk, C++] Fix cilk testsuite failure From: Steve Ellcey To: Richard Sandiford CC: Andrew Pinski , Jeff Law , "GCC Patches" Date: Fri, 17 Jan 2014 10:11:42 -0800 In-Reply-To: <87vbxjm2ye.fsf@talisman.default> References: <5676f26c-f6d8-4798-8bdc-2b7b07f08925@BAMAIL02.ba.imgtec.org> <52D77276.80201@redhat.com> <1389904644.3022.32.camel@ubuntu-sellcey> <1389914554.3022.42.camel@ubuntu-sellcey> <1389917678.3022.45.camel@ubuntu-sellcey> <87vbxjm2ye.fsf@talisman.default> MIME-Version: 1.0 X-SEF-Processed: 7_3_0_01192__2014_01_17_18_11_45 On Fri, 2014-01-17 at 08:23 +0000, Richard Sandiford wrote: > > I think it'd be more direct to check the register class, since we used > to store CCmode in GPRs too. I.e. ST_REGNO_P (XEXP (op, 0)). > > OK with that change, thanks. Please backport to 4.8 too. > > Richard I assume you meant ST_REG_P instead of ST_REGNO_P and it looks like ST_REG_P wants a register number as an argument so the patch I tested and checked in is: If no issues come up over the weekend with this patch I will backport it to the 4.8 branch next week. Steve Ellcey sellcey@mips.com diff --git a/gcc/config/mips/mips.c b/gcc/config/mips/mips.c index 617391c..ff28750 100644 --- a/gcc/config/mips/mips.c +++ b/gcc/config/mips/mips.c @@ -8184,7 +8184,7 @@ mips_print_operand (FILE *file, rtx op, int letter) case 't': { int truth = (code == NE) == (letter == 'T'); - fputc ("zfnt"[truth * 2 + (GET_MODE (op) == CCmode)], file); + fputc ("zfnt"[truth * 2 + ST_REG_P (REGNO (XEXP (op, 0)))], file); } break;