Message ID | 1389944779-31899-5-git-send-email-qiaonuohan@cn.fujitsu.com |
---|---|
State | New |
Headers | show |
On 01/17/14 08:46, qiaonuohan wrote: > Function is used to write vmcore in flatten format. In flatten format, data is > written block by block, and in front of each block, a struct > MakedumpfileDataHeader is stored there to indicate the offset and size of the > data block. > > struct MakedumpfileDataHeader { > int64_t offset; > int64_t buf_size; > }; > > Signed-off-by: Qiao Nuohan <qiaonuohan@cn.fujitsu.com> > Reviewed-by: Laszlo Ersek <lersek@redhat.com> > --- > dump.c | 21 +++++++++++++++++++++ > 1 files changed, 21 insertions(+), 0 deletions(-) Compared with v6 03/11, this patch hardwires the flat format (and adapts the commit message too). My R-b stands. Laszlo
diff --git a/dump.c b/dump.c index f233b3e..238ffa5 100644 --- a/dump.c +++ b/dump.c @@ -728,6 +728,27 @@ static int write_end_flat_header(int fd) return 0; } +static int write_buffer(int fd, off_t offset, const void *buf, size_t size) +{ + size_t written_size; + MakedumpfileDataHeader mdh; + + mdh.offset = cpu_to_be64(offset); + mdh.buf_size = cpu_to_be64(size); + + written_size = qemu_write_full(fd, &mdh, sizeof(mdh)); + if (written_size != sizeof(mdh)) { + return -1; + } + + written_size = qemu_write_full(fd, buf, size); + if (written_size != size) { + return -1; + } + + return 0; +} + static ram_addr_t get_start_block(DumpState *s) { GuestPhysBlock *block;