Patchwork [AArch64] Specify CRC and Crypto support for Cortex-A53, A57

login
register
mail settings
Submitter Kyrylo Tkachov
Date Jan. 16, 2014, 6:10 p.m.
Message ID <52D820AA.1040107@arm.com>
Download mbox | patch
Permalink /patch/311814/
State New
Headers show

Comments

Kyrylo Tkachov - Jan. 16, 2014, 6:10 p.m.
Hi all,

The Cortex-A53 and Cortex-A57 cores support the CRC32 and Crypto extensions to 
the ARMv8-A architecture. This patch adds that information to their definitions 
in aarch64-cores.def.

Tested aarch64-none-elf with no regressions.

Ok for trunk? (or next stage1)?

Thanks,
Kyrill

2014-01-16  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>

     * config/aarch64/aarch64-cores.def (cortex-a53): Specify CRC32
     and crypto support.
     (cortex-a57): Likewise.
     (cortex-a57.cortex-a53): Likewise.
Kyrylo Tkachov - Jan. 23, 2014, 8:58 a.m.
On 16/01/14 18:10, Kyrill Tkachov wrote:
> Hi all,
>
> The Cortex-A53 and Cortex-A57 cores support the CRC32 and Crypto extensions to
> the ARMv8-A architecture. This patch adds that information to their definitions
> in aarch64-cores.def.
>
> Tested aarch64-none-elf with no regressions.
>
> Ok for trunk? (or next stage1)?
>
> Thanks,
> Kyrill
>
> 2014-01-16  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
>
>       * config/aarch64/aarch64-cores.def (cortex-a53): Specify CRC32
>       and crypto support.
>       (cortex-a57): Likewise.
>       (cortex-a57.cortex-a53): Likewise.

Ping.

Kyrill
Kyrylo Tkachov - Jan. 29, 2014, 5:42 p.m.
On 23/01/14 08:58, Kyrill Tkachov wrote:
> On 16/01/14 18:10, Kyrill Tkachov wrote:
>> Hi all,
>>
>> The Cortex-A53 and Cortex-A57 cores support the CRC32 and Crypto extensions to
>> the ARMv8-A architecture. This patch adds that information to their definitions
>> in aarch64-cores.def.
>>
>> Tested aarch64-none-elf with no regressions.
>>
>> Ok for trunk? (or next stage1)?
>>
>> Thanks,
>> Kyrill
>>
>> 2014-01-16  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
>>
>>        * config/aarch64/aarch64-cores.def (cortex-a53): Specify CRC32
>>        and crypto support.
>>        (cortex-a57): Likewise.
>>        (cortex-a57.cortex-a53): Likewise.
> Ping.

Ping^2

Kyrill

>
> Kyrill
>
>
Kyrylo Tkachov - Feb. 6, 2014, 9:37 a.m.
On 29/01/14 17:42, Kyrill Tkachov wrote:
> On 23/01/14 08:58, Kyrill Tkachov wrote:
>> On 16/01/14 18:10, Kyrill Tkachov wrote:
>>> Hi all,
>>>
>>> The Cortex-A53 and Cortex-A57 cores support the CRC32 and Crypto extensions to
>>> the ARMv8-A architecture. This patch adds that information to their definitions
>>> in aarch64-cores.def.
>>>
>>> Tested aarch64-none-elf with no regressions.
>>>
>>> Ok for trunk? (or next stage1)?
>>>
>>> Thanks,
>>> Kyrill
>>>
>>> 2014-01-16  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
>>>
>>>         * config/aarch64/aarch64-cores.def (cortex-a53): Specify CRC32
>>>         and crypto support.
>>>         (cortex-a57): Likewise.
>>>         (cortex-a57.cortex-a53): Likewise.
>> Ping.
> Ping^2

Ping^3

http://gcc.gnu.org/ml/gcc-patches/2014-01/msg01012.html

Kyrill

> Kyrill
>
>> Kyrill
>>
>>
Marcus Shawcroft - Feb. 6, 2014, 9:53 a.m.
On 16 January 2014 18:10, Kyrill Tkachov <kyrylo.tkachov@arm.com> wrote:
> Hi all,
>
> The Cortex-A53 and Cortex-A57 cores support the CRC32 and Crypto extensions
> to the ARMv8-A architecture. This patch adds that information to their
> definitions in aarch64-cores.def.

Both cortex-a53 and cortex-a57 can be configured without crypto
support. The behavior of -mcpu=cortex-a5[37] should be to assume the
presence of crypto, we will need to add support for -mcpu=core+feature
in the future in order to provide a mechanism to turn off crypto.

I think this patch is  OK and should go in now.

/Marcus

Patch

diff --git a/gcc/config/aarch64/aarch64-cores.def b/gcc/config/aarch64/aarch64-cores.def
index a41d7d9..1039660 100644
--- a/gcc/config/aarch64/aarch64-cores.def
+++ b/gcc/config/aarch64/aarch64-cores.def
@@ -34,9 +34,9 @@ 
 
 /* V8 Architecture Processors.  */
 
-AARCH64_CORE("cortex-a53",  cortexa53, cortexa53, 8,  AARCH64_FL_FPSIMD, cortexa53)
-AARCH64_CORE("cortex-a57",  cortexa15, cortexa15, 8,  AARCH64_FL_FPSIMD, generic)
+AARCH64_CORE("cortex-a53",  cortexa53, cortexa53, 8,  AARCH64_FL_FPSIMD | AARCH64_FL_CRC | AARCH64_FL_CRYPTO, cortexa53)
+AARCH64_CORE("cortex-a57",  cortexa15, cortexa15, 8,  AARCH64_FL_FPSIMD | AARCH64_FL_CRC | AARCH64_FL_CRYPTO, generic)
 
 /* V8 big.LITTLE implementations.  */
 
-AARCH64_CORE("cortex-a57.cortex-a53",  cortexa57cortexa53, cortexa53, 8,  AARCH64_FL_FPSIMD, generic)
+AARCH64_CORE("cortex-a57.cortex-a53",  cortexa57cortexa53, cortexa53, 8,  AARCH64_FL_FPSIMD | AARCH64_FL_CRC | AARCH64_FL_CRYPTO, generic)