Patchwork fix doc header in contrib/mklog

login
register
mail settings
Submitter Jonathan Wakely
Date Jan. 16, 2014, 2:44 p.m.
Message ID <CAH6eHdSKpQZLWFB7GgfzojjwNC++KNW6GfVxNu_a30=NFbzdZw@mail.gmail.com>
Download mbox | patch
Permalink /patch/311740/
State New
Headers show

Comments

Jonathan Wakely - Jan. 16, 2014, 2:44 p.m.
The mklog script claims to write to stdout, but it actually modifies
the input file in-place.

OK to commit this change, which also updates the copyright dates?
Diego Novillo - Jan. 17, 2014, 11:30 p.m.
The patch is OK. It qualifies as obvious, too. Thanks.

On Thu, Jan 16, 2014 at 6:44 AM, Jonathan Wakely <jwakely.gcc@gmail.com> wrote:
> The mklog script claims to write to stdout, but it actually modifies
> the input file in-place.
>
> OK to commit this change, which also updates the copyright dates?

Patch

diff --git a/contrib/mklog b/contrib/mklog
index fb0514f..4893e0c 100755
--- a/contrib/mklog
+++ b/contrib/mklog
@@ -1,5 +1,5 @@ 
 #!/usr/bin/perl
-# Copyright (C) 2012 Free Software Foundation, Inc.
+# Copyright (C) 2012-2014 Free Software Foundation, Inc.
 #
 # This file is part of GCC.
 #
@@ -19,7 +19,7 @@ 
 # Boston, MA 02110-1301, USA.
 
 # This script parses a .diff file generated with 'diff -up' or 'diff -cp'
-# and writes a skeleton ChangeLog file to stdout. It does not try to be
+# and adds a skeleton ChangeLog file to the file. It does not try to be
 # very smart when parsing function names, but it produces a reasonable
 # approximation.
 #