From patchwork Tue Aug 11 21:14:46 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Reimar_D=C3=B6ffinger?= X-Patchwork-Id: 31164 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by bilbo.ozlabs.org (Postfix) with ESMTPS id EA1B7B6F20 for ; Wed, 12 Aug 2009 07:16:53 +1000 (EST) Received: from localhost ([127.0.0.1]:39310 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mayi8-0003d2-Ac for incoming@patchwork.ozlabs.org; Tue, 11 Aug 2009 17:16:48 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MaygI-0003Je-QL for qemu-devel@nongnu.org; Tue, 11 Aug 2009 17:14:54 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MaygD-0003Hj-Rb for qemu-devel@nongnu.org; Tue, 11 Aug 2009 17:14:54 -0400 Received: from [199.232.76.173] (port=33559 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MaygD-0003He-Ko for qemu-devel@nongnu.org; Tue, 11 Aug 2009 17:14:49 -0400 Received: from mail.gmx.net ([213.165.64.20]:37311) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1MaygC-0001po-Kt for qemu-devel@nongnu.org; Tue, 11 Aug 2009 17:14:49 -0400 Received: (qmail invoked by alias); 11 Aug 2009 21:14:47 -0000 Received: from p5B1340BE.dip.t-dialin.net (EHLO localhost) [91.19.64.190] by mail.gmx.net (mp052) with SMTP; 11 Aug 2009 23:14:47 +0200 X-Authenticated: #11956158 X-Provags-ID: V01U2FsdGVkX196ftEzEil6OjfXAFALONHB8/j1qcy3FZEh0THp8k Seaxlbb7L2uV0j Date: Tue, 11 Aug 2009 23:14:46 +0200 From: Reimar =?iso-8859-1?Q?D=F6ffinger?= To: qemu-devel@nongnu.org Message-ID: <20090811211446.GB10500@1und1.de> References: <4A81D3F1.1040300@codemonkey.ws> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4A81D3F1.1040300@codemonkey.ws> X-Mailer: git-send-email 1.6.4 User-Agent: Mutt/1.5.20 (2009-06-14) X-Y-GMX-Trusted: 0 X-FuHaFi: 0.59 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: [Qemu-devel] [PATCH 1/5] Setting the MDI SCBAck flag when interrupts for MDI are disabled is wrong, even if it does not seem to cause any real issue with known drivers. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This makes the emulation not set the SBAck flag for MDI interrupts when interrupts are actually disabled for MDI. I think (have not tested yet) that this is not necessary to fix anything, but according to the documentation the current code is wrong. Signed-off-by: Reimar Döffinger --- hw/eepro100.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/hw/eepro100.c b/hw/eepro100.c index ec31a6a..bf5d920 100644 --- a/hw/eepro100.c +++ b/hw/eepro100.c @@ -1043,9 +1043,7 @@ static void eepro100_write_mdi(EEPRO100State * s, uint32_t val) } data = s->mdimem[reg]; } - /* Emulation takes no time to finish MDI transaction. - * Set MDI bit in SCB status register. */ - s->mem[SCBAck] |= 0x08; + /* Emulation takes no time to finish MDI transaction. */ val |= BIT(28); if (raiseint) { eepro100_mdi_interrupt(s);