diff mbox

GNU Make

Message ID CAEsx0Y8rqZ-8Lm-mFnxMT29bmQGpymV1+ZT3yHrF+UTLzhFiUg@mail.gmail.com
State Changes Requested
Headers show

Commit Message

Daniel Schultze Jan. 15, 2014, 10:15 p.m. UTC 
Guys after working with CT-NG for a bit I found the patch directory
and recreated my patch to work with the existing system:
in $CT_NG/patches/glibc/2.10.1/920-glibc-2.10.1-manual-make.patch

On Wed, Jan 15, 2014 at 10:21 AM, Daniel Schultze <kinglag@gmail.com> wrote:
> Hey guys,
>
> I'm new to crosstool-ng, so far it looks like a good utility. I want
> to contribute a patch for glibc 2.10.1 as it will correct its known
> issue with implicit and explicit rules on the same line. Other patches
> can follow the same pattern of moving the rules to separate lines.
>
>
>
> --- glibc-2.10.1/glibc-2.10.1/manual/Makefile-orig 2013-12-06
> 11:03:33.170318872 -0800
> +++ glibc-2.10.1/glibc-2.10.1/manual/Makefile 2013-12-06
> 11:02:35.555022786 -0800
> @@ -232,7 +232,11 @@
>  .PHONY: stubs
>  stubs: $(objpfx)stubs
>  endif
> -$(objpfx)stubs ../po/manual.pot $(objpfx)stamp%:
> +$(objpfx)stamp%:
> + $(make-target-directory)
> + touch $@
> +
> +$(objpfx)stubs ../po/manual.pot:
>   $(make-target-directory)
>   touch $@
>
> -Dan

--
For unsubscribe information see http://sourceware.org/lists.html#faq

Comments

Yann E. MORIN Jan. 15, 2014, 11:16 p.m. UTC | #1 
Daniel, All,

On 2014-01-15 14:15 -0800, Daniel Schultze spake thusly:
> Guys after working with CT-NG for a bit I found the patch directory
> and recreated my patch to work with the existing system:
> in $CT_NG/patches/glibc/2.10.1/920-glibc-2.10.1-manual-make.patch

Yep, that the correct way to add a new patch. :-)

Also, when submitting a patch, you should format it as such (without the
leading 4 spaces):

    component: short description

    One or more paragraph, if needed that describe in more details
    the issue you encountered, hy it happens, and how you fixed it.

    Signed-off-by: Your Real NAME <your.mail@somwhere.net>

For example, for this patch:

    libc/glibc: fix glibc-2.10 for use with make-3.82

    glibc-2.10's Makefile is broken because it mixes implicit and
    normal rules:
        Makefile:235: *** mixed implicit and normal rules. Stop.

    That's because make-3.82 removed this undocumented feature.

    Fix that by splitting the rules in two, as was done in:
        patches/glibc/2.12.1/920-make-382.patch

    Signed-off-by: you

This is all important, to:
  - quickly find the bug it the history log:    subject
  - understand the bug:                         first paragraph
  - confirm the reason:                         second paragraph
  - explain the fix:                            third paragraph
  - assess the origin of the patch:             SoB-line

It is not necessary to write long paragraphs, as long as all the relevant
information is present.

Some doc exists in the tree:
    docs/7 - Contributing to crosstool-NG.txt
    docs/C - Misc. tutorials.txt

Also, the SoB-line is explained in the doc, above, and there:
    http://elinux.org/Developer_Certificate_Of_Origin

The SoB-line is the only thing I can not add for you.

Care to resend with the above suggestions, please?

Regards,
Yann E. MORIN.
diff mbox

Patch

diff -urN glibc-2.10.1-orig/manual/Makefile glibc-2.10.1/manual/Makefile
--- glibc-2.10.1-orig/manual/Makefile 2006-01-07 22:43:47.000000000 -0800
+++ glibc-2.10.1/manual/Makefile 2014-01-15 11:49:08.256982014 -0800
@@ -232,7 +232,11 @@ 
 .PHONY: stubs
 stubs: $(objpfx)stubs
 endif
-$(objpfx)stubs ../po/manual.pot $(objpfx)stamp%:
+$(objpfx)stamp%:
+ $(make-target-directory)
+ touch $@
+
+$(objpfx)stubs ../po/manual.pot:
  $(make-target-directory)
  touch $@