Patchwork Disable PowerMac cpufreq on SMP kernels

login
register
mail settings
Submitter Bastian Blank
Date Aug. 11, 2009, 9:39 a.m.
Message ID <20090811093931.GA15940@wavehammer.waldi.eu.org>
Download mbox | patch
Permalink /patch/31131/
State Changes Requested
Headers show

Comments

Bastian Blank - Aug. 11, 2009, 9:39 a.m.
The build of a PowerMac 32bit kernel currently fails with

error: #warning "WARNING, CPUFREQ not recommended on SMP kernels"

This patch just disables this driver on SMP kernels, as it is obviously
not supported.

Signed-off-by: Bastian Blank <waldi@debian.org>
Benjamin Herrenschmidt - Aug. 13, 2009, 6:14 a.m.
On Tue, 2009-08-11 at 11:39 +0200, Bastian Blank wrote:
> The build of a PowerMac 32bit kernel currently fails with
> 
> error: #warning "WARNING, CPUFREQ not recommended on SMP kernels"
> 
> This patch just disables this driver on SMP kernels, as it is obviously
> not supported.
> 
> Signed-off-by: Bastian Blank <waldi@debian.org>

Why not remove the #error instead ? :-) I don't think it's still
meaningful, especially since we use the timebase for delays nowadays
which doesn't depend on the CPU frequency...

Ben.

> diff --git a/arch/powerpc/platforms/Kconfig b/arch/powerpc/platforms/Kconfig
> index 04a8061..99d3564 100644
> --- a/arch/powerpc/platforms/Kconfig
> +++ b/arch/powerpc/platforms/Kconfig
> @@ -149,7 +149,7 @@ menu "CPU Frequency drivers"
>  
>  config CPU_FREQ_PMAC
>  	bool "Support for Apple PowerBooks"
> -	depends on ADB_PMU && PPC32
> +	depends on ADB_PMU && PPC32 && !SMP
>  	select CPU_FREQ_TABLE
>  	help
>  	  This adds support for frequency switching on Apple PowerBooks,
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

Patch

diff --git a/arch/powerpc/platforms/Kconfig b/arch/powerpc/platforms/Kconfig
index 04a8061..99d3564 100644
--- a/arch/powerpc/platforms/Kconfig
+++ b/arch/powerpc/platforms/Kconfig
@@ -149,7 +149,7 @@  menu "CPU Frequency drivers"
 
 config CPU_FREQ_PMAC
 	bool "Support for Apple PowerBooks"
-	depends on ADB_PMU && PPC32
+	depends on ADB_PMU && PPC32 && !SMP
 	select CPU_FREQ_TABLE
 	help
 	  This adds support for frequency switching on Apple PowerBooks,