Patchwork [buildrobot] vax: Fix unused variable warning

login
register
mail settings
Submitter Jan-Benedict Glaw
Date Jan. 15, 2014, 4:07 p.m.
Message ID <20140115160726.GE24303@lug-owl.de>
Download mbox | patch
Permalink /patch/311185/
State New
Headers show

Comments

Jan-Benedict Glaw - Jan. 15, 2014, 4:07 p.m.
Hi!

Since started, the VAX backend doesn't compile with config-list.mk
because one of VAX's macros doesn't use its argument:

g++ -c   -g -O2 -DIN_GCC  -DCROSS_DIRECTORY_STRUCTURE  -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -Werror -fno-common  -DHAVE_CONFIG_H -I. -I. -I../../../gcc/gcc -I../../../gcc/gcc/. -I../../../gcc/gcc/../include -I../../../gcc/gcc/../libcpp/include -I/opt/cfarm/mpc/include  -I../../../gcc/gcc/../libdecnumber -I../../../gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I../../../gcc/gcc/../libbacktrace    -o loop-invariant.o -MT loop-invariant.o -MMD -MP -MF ./.deps/loop-invariant.TPo ../../../gcc/gcc/loop-invariant.c
../../../gcc/gcc/loop-invariant.c: In function ‘bool check_dependency(basic_block, df_ref, bitmap)’:
../../../gcc/gcc/loop-invariant.c:789:20: error: unused variable ‘regno’ [-Werror=unused-variable]
       unsigned int regno = DF_REF_REGNO (use);
                    ^
cc1plus: all warnings being treated as errors
make[2]: *** [loop-invariant.o] Error 1


This should fix it:


2014-01-15  Jan-Benedict Glaw  <jbglaw@lug-owl.de>

	* config/vax/vax.h (FUNCTION_ARG_REGNO_P): Vix unused variable warning.
Gerald Pfeifer - Jan. 19, 2014, 12:04 p.m.
Jan-Benedict Glaw wrote
>	* config/vax/vax.h (FUNCTION_ARG_REGNO_P): Vix unused variable
>warning.

Fix? ;-)

And if it's been broken for a while, just go ahead and commit the fix.

Gerald

Patch

--- a/gcc/config/vax/vax.h
+++ b/gcc/config/vax/vax.h
@@ -295,7 +295,7 @@  enum reg_class { NO_REGS, ALL_REGS, LIM_REG_CLASSES };
 /* 1 if N is a possible register number for function argument passing.
    On the VAX, no registers are used in this way.  */
 
-#define FUNCTION_ARG_REGNO_P(N) 0
+#define FUNCTION_ARG_REGNO_P(N) ((void) (N), 0)
 
 /* Define a data type for recording info about an argument list
    during the scan of that argument list.  This data type should