Patchwork [2/2] Only build osdep once

login
register
mail settings
Submitter Anthony Liguori
Date Aug. 10, 2009, 10:16 p.m.
Message ID <1249942586-12671-2-git-send-email-aliguori@us.ibm.com>
Download mbox | patch
Permalink /patch/31109/
State Superseded
Headers show

Comments

Anthony Liguori - Aug. 10, 2009, 10:16 p.m.
We no longer need hackery to work around kqemu

Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
---
 Makefile        |    8 ++++----
 Makefile.target |    2 +-
 osdep.c         |    3 ---
 tool-osdep.c    |    4 ----
 4 files changed, 5 insertions(+), 12 deletions(-)
 delete mode 100644 tool-osdep.c

Patch

diff --git a/Makefile b/Makefile
index 2fe4a66..a8bb657 100644
--- a/Makefile
+++ b/Makefile
@@ -54,7 +54,7 @@  recurse-all: $(SUBDIR_RULES) $(ROMSUBDIR_RULES)
 # block-obj-y is code used by both qemu system emulation and qemu-img
 
 block-obj-y = cutils.o cache-utils.o qemu-malloc.o qemu-option.o module.o
-block-obj-y += nbd.o block.o aio.o aes.o
+block-obj-y += nbd.o block.o aio.o aes.o osdep.o
 block-obj-$(CONFIG_AIO) += posix-aio-compat.o
 
 block-nested-y += cow.o qcow.o vdi.o vmdk.o cloop.o dmg.o bochs.o vpc.o vvfat.o
@@ -170,11 +170,11 @@  libqemu_user.a: $(user-obj-y)
 
 qemu-img.o: qemu-img-cmds.h
 
-qemu-img$(EXESUF): qemu-img.o qemu-tool.o tool-osdep.o $(block-obj-y)
+qemu-img$(EXESUF): qemu-img.o qemu-tool.o $(block-obj-y)
 
-qemu-nbd$(EXESUF):  qemu-nbd.o qemu-tool.o tool-osdep.o $(block-obj-y)
+qemu-nbd$(EXESUF):  qemu-nbd.o qemu-tool.o $(block-obj-y)
 
-qemu-io$(EXESUF):  qemu-io.o qemu-tool.o tool-osdep.o cmd.o $(block-obj-y)
+qemu-io$(EXESUF):  qemu-io.o qemu-tool.o cmd.o $(block-obj-y)
 
 qemu-img-cmds.h: $(SRC_PATH)/qemu-img-cmds.hx
 	$(call quiet-command,sh $(SRC_PATH)/hxtool -h < $< > $@,"  GEN   $@")
diff --git a/Makefile.target b/Makefile.target
index b08526c..725b5c5 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -143,7 +143,7 @@  endif #CONFIG_BSD_USER
 # System emulator target
 ifdef CONFIG_SOFTMMU
 
-obj-y = vl.o osdep.o monitor.o pci.o loader.o isa_mmio.o machine.o \
+obj-y = vl.o monitor.o pci.o loader.o isa_mmio.o machine.o \
         gdbstub.o gdbstub-xml.o msix.o ioport.o qemu-config.o
 # virtio has to be here due to weird dependency between PCI and virtio-net.
 # need to fix this properly
diff --git a/osdep.c b/osdep.c
index baacce7..90cc95f 100644
--- a/osdep.c
+++ b/osdep.c
@@ -33,9 +33,6 @@ 
 #include <sys/statvfs.h>
 #endif
 
-/* FIXME: This file should be target independent. However it has kqemu
-   hacks, so must be built for every target.  */
-
 /* Needed early for CONFIG_BSD etc. */
 #include "config-host.h"
 
diff --git a/tool-osdep.c b/tool-osdep.c
deleted file mode 100644
index 24e6edf..0000000
--- a/tool-osdep.c
+++ /dev/null
@@ -1,4 +0,0 @@ 
-/* Hack to provide a version of osdep.o for qemu-img without conflicting with
-   the (kqemu) target specific osdep.o.  */
-#include "osdep.c"
-