| Message ID | 1389766341-14001-2-git-send-email-horms+renesas@verge.net.au |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
On Wed, 2014-01-15 at 15:12 +0900, Simon Horman wrote: > Return a boolean and use true and false. [] > diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c [] > @@ -310,12 +310,12 @@ static const u16 sh_eth_offset_fast_sh3_sh2[SH_ETH_MAX_REGISTER_OFFSET] = { > [TSU_ADRL31] = 0x01fc, > }; > > -static int sh_eth_is_gether(struct sh_eth_private *mdp) > +static bool sh_eth_is_gether(struct sh_eth_private *mdp) > { > if (mdp->reg_offset == sh_eth_offset_gigabit) > - return 1; > + return true; > else > - return 0; > + return false; > } Or maybe: static bool sh_eth_is_gether(struct sh_eth_private *mdp) { return mdp->reg_offset == sh_eth_offset_gigabit; } -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Jan 15, 2014 at 01:35:20AM -0800, Joe Perches wrote: > On Wed, 2014-01-15 at 15:12 +0900, Simon Horman wrote: > > Return a boolean and use true and false. > [] > > diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c > [] > > @@ -310,12 +310,12 @@ static const u16 sh_eth_offset_fast_sh3_sh2[SH_ETH_MAX_REGISTER_OFFSET] = { > > [TSU_ADRL31] = 0x01fc, > > }; > > > > -static int sh_eth_is_gether(struct sh_eth_private *mdp) > > +static bool sh_eth_is_gether(struct sh_eth_private *mdp) > > { > > if (mdp->reg_offset == sh_eth_offset_gigabit) > > - return 1; > > + return true; > > else > > - return 0; > > + return false; > > } > > Or maybe: > > static bool sh_eth_is_gether(struct sh_eth_private *mdp) > { > return mdp->reg_offset == sh_eth_offset_gigabit; > } Thanks, will do. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c index ba1f6c9..4f5cfad 100644 --- a/drivers/net/ethernet/renesas/sh_eth.c +++ b/drivers/net/ethernet/renesas/sh_eth.c @@ -310,12 +310,12 @@ static const u16 sh_eth_offset_fast_sh3_sh2[SH_ETH_MAX_REGISTER_OFFSET] = { [TSU_ADRL31] = 0x01fc, }; -static int sh_eth_is_gether(struct sh_eth_private *mdp) +static bool sh_eth_is_gether(struct sh_eth_private *mdp) { if (mdp->reg_offset == sh_eth_offset_gigabit) - return 1; + return true; else - return 0; + return false; } static void sh_eth_select_mii(struct net_device *ndev)
Return a boolean and use true and false. Signed-off-by: Simon Horman <horms+renesas@verge.net.au> --- v5 * No change v4 * First post --- drivers/net/ethernet/renesas/sh_eth.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)