| Message ID | 20140114155254.30823.22639.stgit@fimbulvetr.bsc.es |
|---|---|
| State | New |
| Headers | show |
On Tue, Jan 14, 2014 at 04:52:55PM +0100, Lluís Vilanova wrote: > The header is not necessary, given that the simple backend does not define any > inlined tracing routines. > > Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu> > --- > scripts/tracetool/backend/simple.py | 3 --- > trace/simple.c | 1 + > 2 files changed, 1 insertion(+), 3 deletions(-) Thanks, applied to my tracing tree: https://github.com/stefanha/qemu/commits/tracing Stefan
diff --git a/scripts/tracetool/backend/simple.py b/scripts/tracetool/backend/simple.py index 37ef599..30faac9 100644 --- a/scripts/tracetool/backend/simple.py +++ b/scripts/tracetool/backend/simple.py @@ -93,9 +93,6 @@ def c(events): def h(events): - out('#include "trace/simple.h"', - '') - for event in events: out('void trace_%(name)s(%(args)s);', name = event.name, diff --git a/trace/simple.c b/trace/simple.c index 1e3f691..410172e 100644 --- a/trace/simple.c +++ b/trace/simple.c @@ -19,6 +19,7 @@ #include "qemu/timer.h" #include "trace.h" #include "trace/control.h" +#include "trace/simple.h" /** Trace file header event ID */ #define HEADER_EVENT_ID (~(uint64_t)0) /* avoids conflicting with TraceEventIDs */
The header is not necessary, given that the simple backend does not define any inlined tracing routines. Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu> --- scripts/tracetool/backend/simple.py | 3 --- trace/simple.c | 1 + 2 files changed, 1 insertion(+), 3 deletions(-)