| Message ID | 1389710409-14106-2-git-send-email-vbridgers2013@gmail.com |
|---|---|
| State | Superseded, archived |
| Delegated to: | David Miller |
| Headers | show |
On Tue, 2014-01-14 at 08:40 -0600, Vince Bridgers wrote: > This change adds a parameter for the Synopsys 10/100/1000 > stmmac Ethernet driver to configure the maximum frame > size supported by the EMAC driver. Synopsys allows the FIFO > sizes to be configured when the cores are built for a particular > device, but do not provide a way for the driver to read > information from the device about the maximum MTU size > supported as limited by the device's FIFO size. > > Signed-off-by: Vince Bridgers <vbridgers2013@gmail.com> > --- > Documentation/devicetree/bindings/net/stmmac.txt | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/stmmac.txt b/Documentation/devicetree/bindings/net/stmmac.txt > index eba0e5e..26a0ba9 100644 > --- a/Documentation/devicetree/bindings/net/stmmac.txt > +++ b/Documentation/devicetree/bindings/net/stmmac.txt > @@ -30,6 +30,10 @@ Required properties: > > Optional properties: > - mac-address: 6 bytes, mac address > +- snps,max-frame-size: Maximum frame size permitted. This parameter is useful I don't think max-frame-size should be a snps-only binding. Dinh > + since different implementations of the Synopsys MAC may > + have different FIFO sizes depending on the selections > + made in Synopsys Core Consultant. > > Examples: > > @@ -40,5 +44,6 @@ Examples: > interrupts = <24 23>; > interrupt-names = "macirq", "eth_wake_irq"; > mac-address = [000000000000]; /* Filled in by U-Boot */ > + snps,max-frame-size = <3800>; > phy-mode = "gmii"; > }; -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Le mardi 14 janvier 2014, 09:57:36 Dinh Nguyen a écrit : > On Tue, 2014-01-14 at 08:40 -0600, Vince Bridgers wrote: > > This change adds a parameter for the Synopsys 10/100/1000 > > stmmac Ethernet driver to configure the maximum frame > > size supported by the EMAC driver. Synopsys allows the FIFO > > sizes to be configured when the cores are built for a particular > > device, but do not provide a way for the driver to read > > information from the device about the maximum MTU size > > supported as limited by the device's FIFO size. > > > > Signed-off-by: Vince Bridgers <vbridgers2013@gmail.com> > > --- > > > > Documentation/devicetree/bindings/net/stmmac.txt | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/net/stmmac.txt > > b/Documentation/devicetree/bindings/net/stmmac.txt index eba0e5e..26a0ba9 > > 100644 > > --- a/Documentation/devicetree/bindings/net/stmmac.txt > > +++ b/Documentation/devicetree/bindings/net/stmmac.txt > > > > @@ -30,6 +30,10 @@ Required properties: > > Optional properties: > > - mac-address: 6 bytes, mac address > > > > +- snps,max-frame-size: Maximum frame size permitted. This parameter is > > useful > I don't think max-frame-size should be a snps-only binding. Right, and I already made that comment to Vince. Maybe this is just an oversight and mistakenly resubmitted v2 instead of v3?
I'll address comments and resubmit. Vince On Tue, Jan 14, 2014 at 10:07 AM, Florian Fainelli <f.fainelli@gmail.com> wrote: > Le mardi 14 janvier 2014, 09:57:36 Dinh Nguyen a écrit : >> On Tue, 2014-01-14 at 08:40 -0600, Vince Bridgers wrote: >> > This change adds a parameter for the Synopsys 10/100/1000 >> > stmmac Ethernet driver to configure the maximum frame >> > size supported by the EMAC driver. Synopsys allows the FIFO >> > sizes to be configured when the cores are built for a particular >> > device, but do not provide a way for the driver to read >> > information from the device about the maximum MTU size >> > supported as limited by the device's FIFO size. >> > >> > Signed-off-by: Vince Bridgers <vbridgers2013@gmail.com> >> > --- >> > >> > Documentation/devicetree/bindings/net/stmmac.txt | 5 +++++ >> > 1 file changed, 5 insertions(+) >> > >> > diff --git a/Documentation/devicetree/bindings/net/stmmac.txt >> > b/Documentation/devicetree/bindings/net/stmmac.txt index eba0e5e..26a0ba9 >> > 100644 >> > --- a/Documentation/devicetree/bindings/net/stmmac.txt >> > +++ b/Documentation/devicetree/bindings/net/stmmac.txt >> > >> > @@ -30,6 +30,10 @@ Required properties: >> > Optional properties: >> > - mac-address: 6 bytes, mac address >> > >> > +- snps,max-frame-size: Maximum frame size permitted. This parameter is >> > useful >> I don't think max-frame-size should be a snps-only binding. > > Right, and I already made that comment to Vince. Maybe this is just an > oversight and mistakenly resubmitted v2 instead of v3? > -- > Florian -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/net/stmmac.txt b/Documentation/devicetree/bindings/net/stmmac.txt index eba0e5e..26a0ba9 100644 --- a/Documentation/devicetree/bindings/net/stmmac.txt +++ b/Documentation/devicetree/bindings/net/stmmac.txt @@ -30,6 +30,10 @@ Required properties: Optional properties: - mac-address: 6 bytes, mac address +- snps,max-frame-size: Maximum frame size permitted. This parameter is useful + since different implementations of the Synopsys MAC may + have different FIFO sizes depending on the selections + made in Synopsys Core Consultant. Examples: @@ -40,5 +44,6 @@ Examples: interrupts = <24 23>; interrupt-names = "macirq", "eth_wake_irq"; mac-address = [000000000000]; /* Filled in by U-Boot */ + snps,max-frame-size = <3800>; phy-mode = "gmii"; };
This change adds a parameter for the Synopsys 10/100/1000 stmmac Ethernet driver to configure the maximum frame size supported by the EMAC driver. Synopsys allows the FIFO sizes to be configured when the cores are built for a particular device, but do not provide a way for the driver to read information from the device about the maximum MTU size supported as limited by the device's FIFO size. Signed-off-by: Vince Bridgers <vbridgers2013@gmail.com> --- Documentation/devicetree/bindings/net/stmmac.txt | 5 +++++ 1 file changed, 5 insertions(+)