diff mbox

[U-Boot] board:universal: fix i2c adapter

Message ID 1389683707-31254-1-git-send-email-p.wilczek@samsung.com
State Accepted
Delegated to: Tom Rini
Headers show

Commit Message

Piotr Wilczek Jan. 14, 2014, 7:15 a.m. UTC
Universal uses only one adapter I2C_0.

Signed-off-by: Piotr Wilczek <p.wilczek@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
 board/samsung/universal_c210/universal.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Przemyslaw Marczak Jan. 14, 2014, 8:19 a.m. UTC | #1
Hi,

On 01/14/2014 08:15 AM, Piotr Wilczek wrote:
> Universal uses only one adapter I2C_0.
>
> Signed-off-by: Piotr Wilczek <p.wilczek@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
>   board/samsung/universal_c210/universal.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/board/samsung/universal_c210/universal.c b/board/samsung/universal_c210/universal.c
> index 54d0e1e..3feef3f 100644
> --- a/board/samsung/universal_c210/universal.c
> +++ b/board/samsung/universal_c210/universal.c
> @@ -49,7 +49,7 @@ int power_init_board(void)
>   	 * For PMIC the I2C bus is named as I2C5, but it is connected
>   	 * to logical I2C adapter 0
>   	 */
> -	ret = pmic_init(I2C_5);
> +	ret = pmic_init(I2C_0);
>   	if (ret)
>   		return ret;
>
>

Acked-by: Przemyslaw Marczak <p.marczak@samsung.com>

Thank you,
Przemyslaw Marczak Jan. 20, 2014, 2:06 p.m. UTC | #2
Hello Tom,

On 01/14/2014 09:19 AM, Przemyslaw Marczak wrote:
> Hi,
>
> On 01/14/2014 08:15 AM, Piotr Wilczek wrote:
>> Universal uses only one adapter I2C_0.
>>
>> Signed-off-by: Piotr Wilczek <p.wilczek@samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>> ---
>>   board/samsung/universal_c210/universal.c |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/board/samsung/universal_c210/universal.c
>> b/board/samsung/universal_c210/universal.c
>> index 54d0e1e..3feef3f 100644
>> --- a/board/samsung/universal_c210/universal.c
>> +++ b/board/samsung/universal_c210/universal.c
>> @@ -49,7 +49,7 @@ int power_init_board(void)
>>        * For PMIC the I2C bus is named as I2C5, but it is connected
>>        * to logical I2C adapter 0
>>        */
>> -    ret = pmic_init(I2C_5);
>> +    ret = pmic_init(I2C_0);
>>       if (ret)
>>           return ret;
>>
>>
>
> Acked-by: Przemyslaw Marczak <p.marczak@samsung.com>
>
> Thank you,

This patch was missed, could you please apply this to the release?

Thank you,
Tom Rini Jan. 20, 2014, 11 p.m. UTC | #3
On Tue, Jan 14, 2014 at 08:15:07AM +0100, Piotr Wilczek wrote:

> Universal uses only one adapter I2C_0.
> 
> Signed-off-by: Piotr Wilczek <p.wilczek@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> Acked-by: Przemyslaw Marczak <p.marczak@samsung.com>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/board/samsung/universal_c210/universal.c b/board/samsung/universal_c210/universal.c
index 54d0e1e..3feef3f 100644
--- a/board/samsung/universal_c210/universal.c
+++ b/board/samsung/universal_c210/universal.c
@@ -49,7 +49,7 @@  int power_init_board(void)
 	 * For PMIC the I2C bus is named as I2C5, but it is connected
 	 * to logical I2C adapter 0
 	 */
-	ret = pmic_init(I2C_5);
+	ret = pmic_init(I2C_0);
 	if (ret)
 		return ret;