| Message ID | 1389679228-15870-1-git-send-email-sw@weilnetz.de |
|---|---|
| State | Accepted |
| Headers | show |
14.01.2014 10:00, Stefan Weil wrote: > cpu_physical_memory_set_dirty_lebitmap calls getpageaddr and ffsl which are > unavailable for MinGW. As the function is unused for MinGW, it can simply > be excluded from compilation. I applied it to -trivial. But maybe it's better to just move whole thing to kvm-all.c where it is actually used? Thanks, /mjt
Am 14.01.2014 18:26, schrieb Michael Tokarev: > 14.01.2014 10:00, Stefan Weil wrote: >> cpu_physical_memory_set_dirty_lebitmap calls getpageaddr and ffsl which are >> unavailable for MinGW. As the function is unused for MinGW, it can simply >> be excluded from compilation. > I applied it to -trivial. But maybe it's better to just move whole thing to kvm-all.c where > it is actually used? > > Thanks, > > /mjt That's a good suggestion. Juan, a comment in include/exec/ram_addr.h says that those functions will be removed soon. Would you suggest moving them to kvm-all.c now, or would you prefer the conditional compilation for MinGW which I introduced with my patch? Regards, Stefan
Stefan Weil <sw@weilnetz.de> wrote: > Am 14.01.2014 18:26, schrieb Michael Tokarev: >> 14.01.2014 10:00, Stefan Weil wrote: >>> cpu_physical_memory_set_dirty_lebitmap calls getpageaddr and ffsl which are >>> unavailable for MinGW. As the function is unused for MinGW, it can simply >>> be excluded from compilation. >> I applied it to -trivial. But maybe it's better to just move whole >> thing to kvm-all.c where >> it is actually used? >> >> Thanks, >> >> /mjt > > That's a good suggestion. Let it as your change. Functions on ram_addr.h should be opaque, and nothing else should access the bitmap. > > Juan, a comment in include/exec/ram_addr.h says that those functions > will be removed soon. Would you suggest moving them to kvm-all.c now, or > would you prefer the conditional compilation for MinGW which I > introduced with my patch? The "soon" was introduced when Memory API was included, and we are still waiting on TCG. Later, Juan.
diff --git a/include/exec/ram_addr.h b/include/exec/ram_addr.h index 33c8acc..481a447 100644 --- a/include/exec/ram_addr.h +++ b/include/exec/ram_addr.h @@ -79,6 +79,7 @@ static inline void cpu_physical_memory_set_dirty_range(ram_addr_t start, xen_modified_memory(start, length); } +#if !defined(_WIN32) static inline void cpu_physical_memory_set_dirty_lebitmap(unsigned long *bitmap, ram_addr_t start, ram_addr_t pages) @@ -127,6 +128,7 @@ static inline void cpu_physical_memory_set_dirty_lebitmap(unsigned long *bitmap, } } } +#endif /* not _WIN32 */ static inline void cpu_physical_memory_clear_dirty_range(ram_addr_t start, ram_addr_t length,
cpu_physical_memory_set_dirty_lebitmap calls getpageaddr and ffsl which are unavailable for MinGW. As the function is unused for MinGW, it can simply be excluded from compilation. Signed-off-by: Stefan Weil <sw@weilnetz.de> --- include/exec/ram_addr.h | 2 ++ 1 file changed, 2 insertions(+)