| Message ID | 1389636070-26312-1-git-send-email-paul.gortmaker@windriver.com |
|---|---|
| State | Awaiting Upstream, archived |
| Delegated to: | David Miller |
| Headers | show |
Paul Gortmaker <paul.gortmaker@windriver.com> schrieb: >Commit 1d49144c0aaa61be4e3ccbef9cc5c40b0ec5f2fe ("netfilter: nf_tables: >add "inet" table for IPv4/IPv6") allows creation of non-IPV6 enabled >.config files that will fail to configure/link as follows: > >warning: (NF_TABLES_INET) selects NF_TABLES_IPV6 which has unmet direct >dependencies (NET && INET && IPV6 && NETFILTER && NF_TABLES) >warning: (NF_TABLES_INET) selects NF_TABLES_IPV6 which has unmet direct >dependencies (NET && INET && IPV6 && NETFILTER && NF_TABLES) >warning: (NF_TABLES_INET) selects NF_TABLES_IPV6 which has unmet direct >dependencies (NET && INET && IPV6 && NETFILTER && NF_TABLES) >net/built-in.o: In function `nft_reject_eval': >nft_reject.c:(.text+0x651e8): undefined reference to `nf_ip6_checksum' >nft_reject.c:(.text+0x65270): undefined reference to `ip6_route_output' >nft_reject.c:(.text+0x656c4): undefined reference to `ip6_dst_hoplimit' >make: *** [vmlinux] Error 1 > >Since the feature is to allow for a mixed IPV4 and IPV6 table, it >seems sensible to make it depend on IPV6. Acked-by: Patrick McHardy <kaber@trash.net> > >Cc: Patrick McHardy <kaber@trash.net> >Cc: Pablo Neira Ayuso <pablo@netfilter.org> >Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> > >diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig >index afe50c0f526f..c37467562fd0 100644 >--- a/net/netfilter/Kconfig >+++ b/net/netfilter/Kconfig >@@ -429,7 +429,7 @@ config NF_TABLES > To compile it as a module, choose M here. > > config NF_TABLES_INET >- depends on NF_TABLES >+ depends on NF_TABLES && IPV6 > select NF_TABLES_IPV4 > select NF_TABLES_IPV6 > tristate "Netfilter nf_tables mixed IPv4/IPv6 tables support" -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jan 14, 2014 at 11:35:42AM +0000, Patrick McHardy wrote: > Paul Gortmaker <paul.gortmaker@windriver.com> schrieb: > >Commit 1d49144c0aaa61be4e3ccbef9cc5c40b0ec5f2fe ("netfilter: nf_tables: > >add "inet" table for IPv4/IPv6") allows creation of non-IPV6 enabled > >.config files that will fail to configure/link as follows: > > > >warning: (NF_TABLES_INET) selects NF_TABLES_IPV6 which has unmet direct > >dependencies (NET && INET && IPV6 && NETFILTER && NF_TABLES) > >warning: (NF_TABLES_INET) selects NF_TABLES_IPV6 which has unmet direct > >dependencies (NET && INET && IPV6 && NETFILTER && NF_TABLES) > >warning: (NF_TABLES_INET) selects NF_TABLES_IPV6 which has unmet direct > >dependencies (NET && INET && IPV6 && NETFILTER && NF_TABLES) > >net/built-in.o: In function `nft_reject_eval': > >nft_reject.c:(.text+0x651e8): undefined reference to `nf_ip6_checksum' > >nft_reject.c:(.text+0x65270): undefined reference to `ip6_route_output' > >nft_reject.c:(.text+0x656c4): undefined reference to `ip6_dst_hoplimit' > >make: *** [vmlinux] Error 1 > > > >Since the feature is to allow for a mixed IPV4 and IPV6 table, it > >seems sensible to make it depend on IPV6. > > Acked-by: Patrick McHardy <kaber@trash.net> Applied, thanks. @Paul: Please, use netfilter-devel ML instead next time. The netfilter ML is reserved for user questions only. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 14-01-14 10:34 AM, Pablo Neira Ayuso wrote: > On Tue, Jan 14, 2014 at 11:35:42AM +0000, Patrick McHardy wrote: >> Paul Gortmaker <paul.gortmaker@windriver.com> schrieb: >>> Commit 1d49144c0aaa61be4e3ccbef9cc5c40b0ec5f2fe ("netfilter: nf_tables: >>> add "inet" table for IPv4/IPv6") allows creation of non-IPV6 enabled >>> .config files that will fail to configure/link as follows: >>> >>> warning: (NF_TABLES_INET) selects NF_TABLES_IPV6 which has unmet direct >>> dependencies (NET && INET && IPV6 && NETFILTER && NF_TABLES) >>> warning: (NF_TABLES_INET) selects NF_TABLES_IPV6 which has unmet direct >>> dependencies (NET && INET && IPV6 && NETFILTER && NF_TABLES) >>> warning: (NF_TABLES_INET) selects NF_TABLES_IPV6 which has unmet direct >>> dependencies (NET && INET && IPV6 && NETFILTER && NF_TABLES) >>> net/built-in.o: In function `nft_reject_eval': >>> nft_reject.c:(.text+0x651e8): undefined reference to `nf_ip6_checksum' >>> nft_reject.c:(.text+0x65270): undefined reference to `ip6_route_output' >>> nft_reject.c:(.text+0x656c4): undefined reference to `ip6_dst_hoplimit' >>> make: *** [vmlinux] Error 1 >>> >>> Since the feature is to allow for a mixed IPV4 and IPV6 table, it >>> seems sensible to make it depend on IPV6. >> >> Acked-by: Patrick McHardy <kaber@trash.net> > > Applied, thanks. > > @Paul: Please, use netfilter-devel ML instead next time. The netfilter > ML is reserved for user questions only. Thanks. Sure, I can do that. But it would probably be better if get_maintainer.pl didn't emit that particular address then. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig index afe50c0f526f..c37467562fd0 100644 --- a/net/netfilter/Kconfig +++ b/net/netfilter/Kconfig @@ -429,7 +429,7 @@ config NF_TABLES To compile it as a module, choose M here. config NF_TABLES_INET - depends on NF_TABLES + depends on NF_TABLES && IPV6 select NF_TABLES_IPV4 select NF_TABLES_IPV6 tristate "Netfilter nf_tables mixed IPv4/IPv6 tables support"
Commit 1d49144c0aaa61be4e3ccbef9cc5c40b0ec5f2fe ("netfilter: nf_tables: add "inet" table for IPv4/IPv6") allows creation of non-IPV6 enabled .config files that will fail to configure/link as follows: warning: (NF_TABLES_INET) selects NF_TABLES_IPV6 which has unmet direct dependencies (NET && INET && IPV6 && NETFILTER && NF_TABLES) warning: (NF_TABLES_INET) selects NF_TABLES_IPV6 which has unmet direct dependencies (NET && INET && IPV6 && NETFILTER && NF_TABLES) warning: (NF_TABLES_INET) selects NF_TABLES_IPV6 which has unmet direct dependencies (NET && INET && IPV6 && NETFILTER && NF_TABLES) net/built-in.o: In function `nft_reject_eval': nft_reject.c:(.text+0x651e8): undefined reference to `nf_ip6_checksum' nft_reject.c:(.text+0x65270): undefined reference to `ip6_route_output' nft_reject.c:(.text+0x656c4): undefined reference to `ip6_dst_hoplimit' make: *** [vmlinux] Error 1 Since the feature is to allow for a mixed IPV4 and IPV6 table, it seems sensible to make it depend on IPV6. Cc: Patrick McHardy <kaber@trash.net> Cc: Pablo Neira Ayuso <pablo@netfilter.org> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>