diff mbox

nftables: Drop hard coded install using root user owner and group.

Message ID 20140112194211.0570d298@voldemort.scrye.com
State Accepted
Headers show

Commit Message

Kevin Fenzi Jan. 13, 2014, 2:42 a.m. UTC 
Packaging systems build as a non priv user, so can't install as root. Users
 installing from source can 'sudo make install' or run 'make install' as root

Signed-off-by: Kevin Fenzi <kevin@scrye.com>
---
 Makefile.rules.in | 2 +-
 doc/Makefile.in   | 4 ++--
 files/Makefile.in | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

Comments

Patrick McHardy Jan. 13, 2014, 6:37 a.m. UTC | #1 
On Sun, Jan 12, 2014 at 07:42:11PM -0700, Kevin Fenzi wrote:
>  Packaging systems build as a non priv user, so can't install as root. Users
>  installing from source can 'sudo make install' or run 'make install' as root

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/Makefile.rules.in b/Makefile.rules.in
index a93a26b..4a5d413 100644
--- a/Makefile.rules.in
+++ b/Makefile.rules.in
@@ -61,7 +61,7 @@  clean_targets         += $(1)-clean
 $(1)-install:
                        @echo -e "  INSTALL\t$1"
                        $(MKDIR_P) $$(DESTDIR)/$$($(1)-destdir)
-                       $(INSTALL) -m 755 -o root -g root \
+                       $(INSTALL) -m 755 \
                                $(SUBDIR)$(1) \
                                $$(DESTDIR)/$$($(1)-destdir)/$(1)
 install_targets                += $(1)-install
diff --git a/doc/Makefile.in b/doc/Makefile.in
index 2c42d7e..c8c5743 100644
--- a/doc/Makefile.in
+++ b/doc/Makefile.in
@@ -10,11 +10,11 @@  install:    $(mandocs-y) $(pdfdocs-y)
                @echo -e "  INSTALL\tdoc"
                if test -n "$(mandocs-y)"; then \
                        $(MKDIR_P) $(DESTDIR)/${mandir}/man8 ;\
-                       $(INSTALL) -m 755 -o root -g root $(mandocs-y) \
+                       $(INSTALL) -m 755 $(mandocs-y) \
                                        $(DESTDIR)/${mandir}/man8/ ;\
                fi
                if test -n "$(pdfdocs-y)"; then \
                        $(MKDIR_P) $(DESTDIR)/${pdfdir} ;\
-                       $(INSTALL) -m 755 -o root -g root $(pdfdocs-y) \
+                       $(INSTALL) -m 755 $(pdfdocs-y) \
                                        $(DESTDIR)/${pdfdir}/ ;\
                fi
diff --git a/files/Makefile.in b/files/Makefile.in
index cd67c37..0d3390e 100644
--- a/files/Makefile.in
+++ b/files/Makefile.in
@@ -1,4 +1,4 @@ 
 install:
        @echo -e "  INSTALL\tfiles"
        $(MKDIR_P) $(DESTDIR)/$(confdir)
-       $(INSTALL) -m 755 -o root -g root $(SUBDIR)nftables/* $(DESTDIR)/$(confdir)/
+       $(INSTALL) -m 755 $(SUBDIR)nftables/* $(DESTDIR)/$(confdir)/