Patchwork [PATCHv10,1/3] ARM i.MX35: build in pinctrl support.

login
register
mail settings
Submitter Denis Carikli
Date Jan. 10, 2014, 3:40 p.m.
Message ID <1389368441-26310-1-git-send-email-denis@eukrea.com>
Download mbox | patch
Permalink /patch/309313/
State New
Headers show

Comments

Denis Carikli - Jan. 10, 2014, 3:40 p.m.
Cc: Rob Herring <rob.herring@calxeda.com>
Cc: Pawel Moll <pawel.moll@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Stephen Warren <swarren@wwwdotorg.org>
Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>
Cc: devicetree@vger.kernel.org
Cc: Sascha Hauer <kernel@pengutronix.de>
Cc: Shawn Guo <shawn.guo@linaro.org>
Cc: Fabio Estevam <fabio.estevam@freescale.com>
Cc: linux-arm-kernel@lists.infradead.org
Cc: Russell King <linux@arm.linux.org.uk>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Eric Bénard <eric@eukrea.com>
Signed-off-by: Denis Carikli <denis@eukrea.com>
---
ChangeLog v9->v10:
- Added Fabio Estevam to the Cc list.
- Removed the duplicated PINCTRL Kconfig selection for the I.MX35,
  the remaining PINCTRL Kconfig selection is now ordered alphabetically.

ChangeLog v8->v9:
- patch refreshed when applying it.

ChangeLog v7->v8:
- The addition of the imx35 pinctrl driver selection in Kconfig that was in the
  patch adding the devicetree support for the imx35 was moved here.
---
 arch/arm/mach-imx/Kconfig |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Shawn Guo - Jan. 13, 2014, 4:19 a.m.
On Fri, Jan 10, 2014 at 04:40:39PM +0100, Denis Carikli wrote:
> Cc: Rob Herring <rob.herring@calxeda.com>

This is an invalid email address now.

> Cc: Pawel Moll <pawel.moll@arm.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Stephen Warren <swarren@wwwdotorg.org>
> Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>
> Cc: devicetree@vger.kernel.org

I'm not sure why we need to bother device tree folks with such a tiny
SoC change.

OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
M:      Rob Herring <robh+dt@kernel.org>
M:      Pawel Moll <pawel.moll@arm.com>
M:      Mark Rutland <mark.rutland@arm.com>
M:      Ian Campbell <ijc+devicetree@hellion.org.uk>
M:      Kumar Gala <galak@codeaurora.org>
L:      devicetree@vger.kernel.org
S:      Maintained
F:      Documentation/devicetree/
F:      arch/*/boot/dts/
F:      include/dt-bindings/

Does arch/arm/mach-imx/Kconfig match any entry above?

Please copy people and lists with some consideration instead of doing
that blindly.

> Cc: Sascha Hauer <kernel@pengutronix.de>
> Cc: Shawn Guo <shawn.guo@linaro.org>
> Cc: Fabio Estevam <fabio.estevam@freescale.com>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: Russell King <linux@arm.linux.org.uk>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Eric Bénard <eric@eukrea.com>
> Signed-off-by: Denis Carikli <denis@eukrea.com>
> ---
> ChangeLog v9->v10:
> - Added Fabio Estevam to the Cc list.
> - Removed the duplicated PINCTRL Kconfig selection for the I.MX35,
>   the remaining PINCTRL Kconfig selection is now ordered alphabetically.
> 
> ChangeLog v8->v9:
> - patch refreshed when applying it.
> 
> ChangeLog v7->v8:
> - The addition of the imx35 pinctrl driver selection in Kconfig that was in the
>   patch adding the devicetree support for the imx35 was moved here.
> ---
>  arch/arm/mach-imx/Kconfig |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
> index b0c6eb3..7778b16c 100644
> --- a/arch/arm/mach-imx/Kconfig
> +++ b/arch/arm/mach-imx/Kconfig
> @@ -125,8 +125,9 @@ config SOC_IMX35
>  	select CPU_V6K
>  	select HAVE_EPIT
>  	select MXC_AVIC
> -	select SMP_ON_UP if SMP
>  	select PINCTRL
> +	select PINCTRL_IMX35

While at it, we should drop 'select PINCTRL', since it's been covered by
ARCH_MXC.

I fixed it up and applied the patch.  Thanks.

Shawn

> +	select SMP_ON_UP if SMP
>  
>  config SOC_IMX5
>  	bool
> -- 
> 1.7.9.5
>

Patch

diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
index b0c6eb3..7778b16c 100644
--- a/arch/arm/mach-imx/Kconfig
+++ b/arch/arm/mach-imx/Kconfig
@@ -125,8 +125,9 @@  config SOC_IMX35
 	select CPU_V6K
 	select HAVE_EPIT
 	select MXC_AVIC
-	select SMP_ON_UP if SMP
 	select PINCTRL
+	select PINCTRL_IMX35
+	select SMP_ON_UP if SMP
 
 config SOC_IMX5
 	bool