Patchwork [v3,net-next] packet: doc: describe PACKET_MMAP with one packet socket for rx and tx

login
register
mail settings
Submitter Daniel Borkmann
Date Jan. 10, 2014, 9:22 a.m.
Message ID <1389345757-13579-1-git-send-email-dborkman@redhat.com>
Download mbox | patch
Permalink /patch/309204/
State Accepted
Delegated to: David Miller
Headers show

Comments

Daniel Borkmann - Jan. 10, 2014, 9:22 a.m.
From: Norbert van Bolhuis <nvbolhuis@aimvalley.nl>

Document how to use one AF_PACKET mmap socket for RX and TX.

Signed-off-by: Norbert van Bolhuis <nvbolhuis@aimvalley.nl>
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
---
 v1->v2:
  - add setsockopt() calls
 v2->v3:
  - did the rebase to net-next for Norbert

 Documentation/networking/packet_mmap.txt | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
David Miller - Jan. 10, 2014, 10:58 p.m.
From: Daniel Borkmann <dborkman@redhat.com>
Date: Fri, 10 Jan 2014 10:22:37 +0100

> From: Norbert van Bolhuis <nvbolhuis@aimvalley.nl>
> 
> Document how to use one AF_PACKET mmap socket for RX and TX.
> 
> Signed-off-by: Norbert van Bolhuis <nvbolhuis@aimvalley.nl>
> Signed-off-by: Daniel Borkmann <dborkman@redhat.com>

Don't you need to evaluate need_rehook with at least the socket
lock held?

Otherwise how would two parallel bind() calls pan out?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/Documentation/networking/packet_mmap.txt b/Documentation/networking/packet_mmap.txt
index 723bf3d..91ffe1d 100644
--- a/Documentation/networking/packet_mmap.txt
+++ b/Documentation/networking/packet_mmap.txt
@@ -98,6 +98,11 @@  by the kernel.
 The destruction of the socket and all associated resources
 is done by a simple call to close(fd).
 
+Similarly as without PACKET_MMAP, it is possible to use one socket
+for capture and transmission. This can be done by mapping the
+allocated RX and TX buffer ring with a single mmap() call.
+See "Mapping and use of the circular buffer (ring)".
+
 Next I will describe PACKET_MMAP settings and its constraints,
 also the mapping of the circular buffer in the user process and 
 the use of this buffer.
@@ -414,6 +419,19 @@  tp_block_size/tp_frame_size frames there will be a gap between
 the frames. This is because a frame cannot be spawn across two
 blocks. 
 
+To use one socket for capture and transmission, the mapping of both the
+RX and TX buffer ring has to be done with one call to mmap:
+
+    ...
+    setsockopt(fd, SOL_PACKET, PACKET_RX_RING, &foo, sizeof(foo));
+    setsockopt(fd, SOL_PACKET, PACKET_TX_RING, &bar, sizeof(bar));
+    ...
+    rx_ring = mmap(0, size * 2, PROT_READ|PROT_WRITE, MAP_SHARED, fd, 0);
+    tx_ring = rx_ring + size;
+
+RX must be the first as the kernel maps the TX ring memory right
+after the RX one.
+
 At the beginning of each frame there is an status field (see 
 struct tpacket_hdr). If this field is 0 means that the frame is ready
 to be used for the kernel, If not, there is a frame the user can read