From patchwork Fri Aug 7 03:34:48 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Mundt X-Patchwork-Id: 30910 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by bilbo.ozlabs.org (Postfix) with ESMTPS id AE53DB6F31 for ; Fri, 7 Aug 2009 13:37:22 +1000 (EST) Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1MZGEN-0004wM-2x; Fri, 07 Aug 2009 03:34:59 +0000 Received: from 124x34x33x190.ap124.ftth.ucom.ne.jp ([124.34.33.190] helo=master.linux-sh.org) by bombadil.infradead.org with esmtps (Exim 4.69 #1 (Red Hat Linux)) id 1MZGEF-0004vu-SW for linux-mtd@lists.infradead.org; Fri, 07 Aug 2009 03:34:56 +0000 Received: from localhost (unknown [127.0.0.1]) by master.linux-sh.org (Postfix) with ESMTP id 910FD6375A; Fri, 7 Aug 2009 03:34:48 +0000 (UTC) X-Virus-Scanned: amavisd-new at linux-sh.org Received: from master.linux-sh.org ([127.0.0.1]) by localhost (master.linux-sh.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oEQmoQ8lAsUs; Fri, 7 Aug 2009 12:34:48 +0900 (JST) Received: by master.linux-sh.org (Postfix, from userid 500) id 384976375B; Fri, 7 Aug 2009 12:34:48 +0900 (JST) Date: Fri, 7 Aug 2009 12:34:48 +0900 From: Paul Mundt To: Andrew Morton Subject: Re: mmotm 2009-08-06-00-30 uploaded (mtd) Message-ID: <20090807033448.GA32592@linux-sh.org> Mail-Followup-To: Paul Mundt , Andrew Morton , Randy Dunlap , linux-kernel@vger.kernel.org, Magnus Damm , David Woodhouse , linux-mtd@lists.infradead.org References: <200908060733.n767X6mN023120@imap1.linux-foundation.org> <20090806190233.6d4b4e28.randy.dunlap@oracle.com> <20090806192513.53f6488b.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20090806192513.53f6488b.akpm@linux-foundation.org> User-Agent: Mutt/1.5.13 (2006-08-11) X-Spam-Score: 1.7 (+) X-Spam-Report: SpamAssassin version 3.2.5 on bombadil.infradead.org summary: Content analysis details: (1.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- 1.6 RCVD_IN_SORBS_DUL RBL: SORBS: sent directly from dynamic IP address [124.34.33.190 listed in dnsbl.sorbs.net] 0.1 RDNS_DYNAMIC Delivered to trusted network by host with dynamic-looking rDNS Cc: Randy Dunlap , Magnus Damm , David Woodhouse , linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org On Thu, Aug 06, 2009 at 07:25:13PM -0700, Andrew Morton wrote: > On Thu, 6 Aug 2009 19:02:33 -0700 Randy Dunlap wrote: > > > On Thu, 06 Aug 2009 00:33:06 -0700 akpm@linux-foundation.org wrote: > > > > > The mm-of-the-moment snapshot 2009-08-06-00-30 has been uploaded to > > > > > > http://userweb.kernel.org/~akpm/mmotm/ > > > > > > and will soon be available at > > > > > > git://git.zen-sources.org/zen/mmotm.git > > > > > > It contains the following patches against 2.6.31-rc5: > > > > > > > > drivers/built-in.o: In function `generic_onenand_remove': > > generic.c:(.devexit.text+0x1b8e): undefined reference to `del_mtd_partitions' > > > > config attached. > > Thanks. It's mtd-make-onenand-genericc-more-generic.patch. > Wow, I guess ARM people don't do randconfigs. --- [PATCH] mtd: onenand: select MTD_PARTITIONS. All of the onenand drivers depend on mtd partition support being compiled in, so just select it. Fixes up build breakage: drivers/built-in.o: In function `generic_onenand_remove': generic.c:(.devexit.text+0x80): undefined reference to `del_mtd_partitions' Reported-by: Randy Dunlap Signed-off-by: Paul Mundt --- drivers/mtd/onenand/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/onenand/Kconfig b/drivers/mtd/onenand/Kconfig index 2d6b7c1..a38f580 100644 --- a/drivers/mtd/onenand/Kconfig +++ b/drivers/mtd/onenand/Kconfig @@ -5,6 +5,7 @@ menuconfig MTD_ONENAND tristate "OneNAND Device Support" depends on MTD + select MTD_PARTITIONS help This enables support for accessing all type of OneNAND flash devices. For further information see @@ -65,7 +66,6 @@ config MTD_ONENAND_2X_PROGRAM config MTD_ONENAND_SIM tristate "OneNAND simulator support" - depends on MTD_PARTITIONS help The simulator may simulate various OneNAND flash chips for the OneNAND MTD layer.