Patchwork mmotm 2009-08-06-00-30 uploaded (mtd)

login
register
mail settings
Submitter Paul Mundt
Date Aug. 7, 2009, 3:34 a.m.
Message ID <20090807033448.GA32592@linux-sh.org>
Download mbox | patch
Permalink /patch/30910/
State New
Headers show

Comments

Paul Mundt - Aug. 7, 2009, 3:34 a.m.
On Thu, Aug 06, 2009 at 07:25:13PM -0700, Andrew Morton wrote:
> On Thu, 6 Aug 2009 19:02:33 -0700 Randy Dunlap <randy.dunlap@oracle.com> wrote:
> 
> > On Thu, 06 Aug 2009 00:33:06 -0700 akpm@linux-foundation.org wrote:
> > 
> > > The mm-of-the-moment snapshot 2009-08-06-00-30 has been uploaded to
> > > 
> > >    http://userweb.kernel.org/~akpm/mmotm/
> > > 
> > > and will soon be available at
> > > 
> > >    git://git.zen-sources.org/zen/mmotm.git
> > > 
> > > It contains the following patches against 2.6.31-rc5:
> > 
> > 
> > 
> > drivers/built-in.o: In function `generic_onenand_remove':
> > generic.c:(.devexit.text+0x1b8e): undefined reference to `del_mtd_partitions'
> > 
> > config attached.
> 
> Thanks.  It's mtd-make-onenand-genericc-more-generic.patch.
> 
Wow, I guess ARM people don't do randconfigs.

---

[PATCH] mtd: onenand: select MTD_PARTITIONS.

All of the onenand drivers depend on mtd partition support being compiled
in, so just select it. Fixes up build breakage:

drivers/built-in.o: In function `generic_onenand_remove':
generic.c:(.devexit.text+0x80): undefined reference to `del_mtd_partitions'

Reported-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Paul Mundt <lethal@linux-sh.org>

---

 drivers/mtd/onenand/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Randy Dunlap - Aug. 7, 2009, 4 a.m.
On Fri, 7 Aug 2009 12:34:48 +0900 Paul Mundt wrote:

> On Thu, Aug 06, 2009 at 07:25:13PM -0700, Andrew Morton wrote:
> > On Thu, 6 Aug 2009 19:02:33 -0700 Randy Dunlap <randy.dunlap@oracle.com> wrote:
> > 
> > > On Thu, 06 Aug 2009 00:33:06 -0700 akpm@linux-foundation.org wrote:
> > > 
> > > > The mm-of-the-moment snapshot 2009-08-06-00-30 has been uploaded to
> > > > 
> > > >    http://userweb.kernel.org/~akpm/mmotm/
> > > > 
> > > > and will soon be available at
> > > > 
> > > >    git://git.zen-sources.org/zen/mmotm.git
> > > > 
> > > > It contains the following patches against 2.6.31-rc5:
> > > 
> > > 
> > > 
> > > drivers/built-in.o: In function `generic_onenand_remove':
> > > generic.c:(.devexit.text+0x1b8e): undefined reference to `del_mtd_partitions'
> > > 
> > > config attached.
> > 
> > Thanks.  It's mtd-make-onenand-genericc-more-generic.patch.
> > 
> Wow, I guess ARM people don't do randconfigs.
> 
> ---
> 
> [PATCH] mtd: onenand: select MTD_PARTITIONS.
> 
> All of the onenand drivers depend on mtd partition support being compiled
> in, so just select it. Fixes up build breakage:
> 
> drivers/built-in.o: In function `generic_onenand_remove':
> generic.c:(.devexit.text+0x80): undefined reference to `del_mtd_partitions'
> 
> Reported-by: Randy Dunlap <randy.dunlap@oracle.com>
> Signed-off-by: Paul Mundt <lethal@linux-sh.org>

Ack.  Thanks.

> ---
> 
>  drivers/mtd/onenand/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/onenand/Kconfig b/drivers/mtd/onenand/Kconfig
> index 2d6b7c1..a38f580 100644
> --- a/drivers/mtd/onenand/Kconfig
> +++ b/drivers/mtd/onenand/Kconfig
> @@ -5,6 +5,7 @@
>  menuconfig MTD_ONENAND
>  	tristate "OneNAND Device Support"
>  	depends on MTD
> +	select MTD_PARTITIONS
>  	help
>  	  This enables support for accessing all type of OneNAND flash
>  	  devices. For further information see
> @@ -65,7 +66,6 @@ config MTD_ONENAND_2X_PROGRAM
>  
>  config MTD_ONENAND_SIM
>  	tristate "OneNAND simulator support"
> -	depends on MTD_PARTITIONS
>  	help
>  	  The simulator may simulate various OneNAND flash chips for the
>  	  OneNAND MTD layer.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/


---
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/
Artem Bityutskiy - Aug. 10, 2009, 7:01 a.m.
On Fri, 2009-08-07 at 12:34 +0900, Paul Mundt wrote:
> [PATCH] mtd: onenand: select MTD_PARTITIONS.
> 
> All of the onenand drivers depend on mtd partition support being compiled
> in, so just select it. Fixes up build breakage:
> 
> drivers/built-in.o: In function `generic_onenand_remove':
> generic.c:(.devexit.text+0x80): undefined reference to `del_mtd_partitions'
> 
> Reported-by: Randy Dunlap <randy.dunlap@oracle.com>
> Signed-off-by: Paul Mundt <lethal@linux-sh.org>

Hopefully someday we are going to remove this config options, remove
the mtdpart module, and make partitions mandatory. Currently it is
a mess, IMO.

I've just put this patch to my l2-mtd-2.6.git tree.

Artem.

Patch

diff --git a/drivers/mtd/onenand/Kconfig b/drivers/mtd/onenand/Kconfig
index 2d6b7c1..a38f580 100644
--- a/drivers/mtd/onenand/Kconfig
+++ b/drivers/mtd/onenand/Kconfig
@@ -5,6 +5,7 @@ 
 menuconfig MTD_ONENAND
 	tristate "OneNAND Device Support"
 	depends on MTD
+	select MTD_PARTITIONS
 	help
 	  This enables support for accessing all type of OneNAND flash
 	  devices. For further information see
@@ -65,7 +66,6 @@  config MTD_ONENAND_2X_PROGRAM
 
 config MTD_ONENAND_SIM
 	tristate "OneNAND simulator support"
-	depends on MTD_PARTITIONS
 	help
 	  The simulator may simulate various OneNAND flash chips for the
 	  OneNAND MTD layer.