Patchwork [3/8] drivers/mtd/mtdcore.c: make symbols static

login
register
mail settings
Submitter Andrew Morton
Date Aug. 6, 2009, 11:05 p.m.
Message ID <200908062305.n76N5XFO004949@imap1.linux-foundation.org>
Download mbox | patch
Permalink /patch/30899/
State New, archived
Headers show

Comments

Andrew Morton - Aug. 6, 2009, 11:05 p.m.
From: H Hartley Sweeten <hartleys@visionengravers.com>

Make mtd_group and mtd_groups static since they are only used in this
file.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: David Woodhouse <dwmw2@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/mtd/mtdcore.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Artem Bityutskiy - Aug. 10, 2009, 7:20 a.m.
On Thu, 2009-08-06 at 16:05 -0700, akpm@linux-foundation.org wrote:
> From: H Hartley Sweeten <hartleys@visionengravers.com>
> 
> Make mtd_group and mtd_groups static since they are only used in this
> file.
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: David Woodhouse <dwmw2@infradead.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

This one is in my l2-mtd-2.6.git now.

Patch

diff -puN drivers/mtd/mtdcore.c~drivers-mtd-mtdcorec-make-symbols-static drivers/mtd/mtdcore.c
--- a/drivers/mtd/mtdcore.c~drivers-mtd-mtdcorec-make-symbols-static
+++ a/drivers/mtd/mtdcore.c
@@ -213,11 +213,11 @@  static struct attribute *mtd_attrs[] = {
 	NULL,
 };
 
-struct attribute_group mtd_group = {
+static struct attribute_group mtd_group = {
 	.attrs		= mtd_attrs,
 };
 
-const struct attribute_group *mtd_groups[] = {
+static const struct attribute_group *mtd_groups[] = {
 	&mtd_group,
 	NULL,
 };