From patchwork Thu Jan 9 15:24:10 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 308859 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id A5AA52C00BB for ; Fri, 10 Jan 2014 02:24:41 +1100 (EST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1W1HTM-0007FA-JE; Thu, 09 Jan 2014 15:24:40 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1W1HSt-0007Ef-HK for fwts-devel@lists.ubuntu.com; Thu, 09 Jan 2014 15:24:11 +0000 Received: from cpc3-craw6-2-0-cust180.croy.cable.virginm.net ([77.100.248.181] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1W1HSt-0007hh-Eq for fwts-devel@lists.ubuntu.com; Thu, 09 Jan 2014 15:24:11 +0000 From: Colin King To: fwts-devel@lists.ubuntu.com Subject: [PATCH] acpi: powerbutton: ensure we don't get scanf buffer overflow Date: Thu, 9 Jan 2014 15:24:10 +0000 Message-Id: <1389281050-24674-1-git-send-email-colin.king@canonical.com> X-Mailer: git-send-email 1.8.5.2 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.14 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: fwts-devel-bounces@lists.ubuntu.com From: Colin Ian King Signed-off-by: Colin Ian King Acked-by: Ivan Hu Acked-by: Alex Hung --- src/acpi/powerbutton/powerbutton.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/acpi/powerbutton/powerbutton.c b/src/acpi/powerbutton/powerbutton.c index b67cbcd..5bf14a7 100644 --- a/src/acpi/powerbutton/powerbutton.c +++ b/src/acpi/powerbutton/powerbutton.c @@ -62,7 +62,7 @@ static int power_button_test1(fwts_framework *fw) else { char button[4096]; memset(button, 0, sizeof(button)); - sscanf(buffer, "%*s %s", button); + sscanf(buffer, "%*s %4095s", button); fwts_passed(fw, "Detected %s power button event.", button); }