From patchwork Thu Jan 9 14:31:58 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mateusz Zalega X-Patchwork-Id: 308823 X-Patchwork-Delegate: promsoft@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id DB1F42C00BD for ; Fri, 10 Jan 2014 01:40:30 +1100 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 3394E4AC6E; Thu, 9 Jan 2014 15:40:26 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4jceUZsXthmc; Thu, 9 Jan 2014 15:40:25 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 587004ABCC; Thu, 9 Jan 2014 15:40:01 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 5B66B4AA7C for ; Thu, 9 Jan 2014 15:39:57 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 26x0cgkSsQ8P for ; Thu, 9 Jan 2014 15:39:52 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mailout3.w1.samsung.com (mailout3.w1.samsung.com [210.118.77.13]) by theia.denx.de (Postfix) with ESMTPS id 462524AAC1 for ; Thu, 9 Jan 2014 15:39:47 +0100 (CET) Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout3.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MZ5003PP1LAKMA0@mailout3.w1.samsung.com> for u-boot@lists.denx.de; Thu, 09 Jan 2014 14:29:34 +0000 (GMT) X-AuditID: cbfec7f4-b7f796d000005a13-2c-52ceb24d9e40 Received: from eusync4.samsung.com ( [203.254.199.214]) by eucpsbgm1.samsung.com (EUCPMTA) with SMTP id 08.2D.23059.D42BEC25; Thu, 09 Jan 2014 14:29:33 +0000 (GMT) Received: from kernelpanic.DIGITAL.local ([106.120.53.14]) by eusync4.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MZ5004DQ1L7WS60@eusync4.samsung.com>; Thu, 09 Jan 2014 14:29:33 +0000 (GMT) From: Mateusz Zalega To: u-boot@lists.denx.de Date: Thu, 09 Jan 2014 15:31:58 +0100 Message-id: <1389277919-15279-8-git-send-email-m.zalega@samsung.com> X-Mailer: git-send-email 1.8.2.1 In-reply-to: <1389277919-15279-1-git-send-email-m.zalega@samsung.com> References: <1389277919-15279-1-git-send-email-m.zalega@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrHJMWRmVeSWpSXmKPExsVy+t/xa7q+m84FGbw+pGtxtukNu8Wbh5sZ Lea+m8Jk0XGkhdHi7d5OdgdWj7N3djB69G1ZxRjAFMVlk5Kak1mWWqRvl8CV8fLUGZaCr2wV +zd9Y2tgfMXaxcjJISFgItG39SIjhC0mceHeerYuRi4OIYGljBLr9x2AcvqZJJ5d7ACrYhPQ lrixdz47iC0iICHxq/8qI0gRs8AyRolpWz8ydTFycAgLuEk8OqUFUsMioCqxcOlmsF5eAReJ G3+WMENsU5A4vn0bWJxTwFXiVU8jmC0EVNO46S/LBEbeBYwMqxhFU0uTC4qT0nMN9YoTc4tL 89L1kvNzNzFCwuTLDsbFx6wOMQpwMCrx8HLUng0SYk0sK67MPcQowcGsJMJrvOFckBBvSmJl VWpRfnxRaU5q8SFGJg5OqQZGhXynTe0azEfvz1346jn3hetzDh/30DgxacPb1EUeelKveG79 qLhuOePKlQUVW4Mv8mcbfG/h/WuyaPP79MrmRyqJ7meTfr/9cUVmrd/FG7fc/BIuB/AeeLY/ v0W+VKx03V6rvzqvbms5Be3LjP1+bJWviMKfl6rhqavzHtu+85khuNldgjHokhJLcUaioRZz UXEiAInvVHzxAQAA Cc: Kyungmin Park Subject: [U-Boot] [PATCH 8/9] ums: always initialize mmc before ums_disk_init() X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.11 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de In some cases MMC was still uninitialized while media capacity check, leading to broken ums command. Change-Id: I4b86c2c59e430fb8b55272ea14f00316d8cb3dca Signed-off-by: Mateusz Zalega Cc: Lukasz Majewski Cc: Minkyu Kang Cc: Kyungmin Park Tested-by: Lukasz Majewski --- board/samsung/common/ums.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/board/samsung/common/ums.c b/board/samsung/common/ums.c index dc155ad..0d8f30d 100644 --- a/board/samsung/common/ums.c +++ b/board/samsung/common/ums.c @@ -37,6 +37,9 @@ static struct ums ums_dev = { static struct ums *ums_disk_init(struct mmc *mmc) { + if (mmc_init(mmc)) + return NULL; + uint64_t mmc_end_sector = mmc->capacity / SECTOR_SIZE; uint64_t ums_end_sector = UMS_NUM_SECTORS + UMS_START_SECTOR;