Patchwork [U-Boot,1/9] mmc: mmc header fix

login
register
mail settings
Submitter Mateusz Zalega
Date Jan. 9, 2014, 2:31 p.m.
Message ID <1389277919-15279-1-git-send-email-m.zalega@samsung.com>
Download mbox | patch
Permalink /patch/308822/
State Changes Requested
Delegated to: Minkyu Kang
Headers show

Comments

Mateusz Zalega - Jan. 9, 2014, 2:31 p.m.
Structure definition used type block_dev_desc_t, defined in part.h, which
wasn't included in mmc.h. It worked only in circumstances when common.h,
or another header using part.h was incuded in implementation files.

Change-Id: I3ccf56ce1e5334c32a7bc061e8bd9a5054ccb7f5
Signed-off-by: Mateusz Zalega <m.zalega@samsung.com>
Cc: Minkyu Kang <mk7.kang@samsung.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
---
 include/mmc.h | 1 +
 1 file changed, 1 insertion(+)
Jaehoon Chung - Jan. 10, 2014, 4:46 a.m.
Looks good to me. CC'd mmc Custodian.

Acked-by: Jaehoon Chung <jh80.chung@samsung.com>

On 01/09/2014 11:31 PM, Mateusz Zalega wrote:
> Structure definition used type block_dev_desc_t, defined in part.h, which
> wasn't included in mmc.h. It worked only in circumstances when common.h,
> or another header using part.h was incuded in implementation files.
> 
> Change-Id: I3ccf56ce1e5334c32a7bc061e8bd9a5054ccb7f5
> Signed-off-by: Mateusz Zalega <m.zalega@samsung.com>
> Cc: Minkyu Kang <mk7.kang@samsung.com>
> Cc: Kyungmin Park <kyungmin.park@samsung.com>
> ---
>  include/mmc.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/mmc.h b/include/mmc.h
> index cb558da..e490a06 100644
> --- a/include/mmc.h
> +++ b/include/mmc.h
> @@ -12,6 +12,7 @@
>  
>  #include <linux/list.h>
>  #include <linux/compiler.h>
> +#include <part.h>
>  
>  #define SD_VERSION_SD	0x20000
>  #define SD_VERSION_3	(SD_VERSION_SD | 0x300)
>
Mateusz Zalega - Feb. 4, 2014, 5:02 p.m.
This is an updated version of patch series regarding DFU, MMC, USB Gadget and
Samsung Goni board, originally sent on 10 January 2014.

---
Changes since v1:
- reordered
  "USB: gadget: added a saner gadget downloader registration API"
- fixed a bug related to usb_cable_connected() which broke previous Goni
  configuration patches
- disabled DFU in TI's am335x SPL build due to insufficient SRAM capacity
---

Mateusz Zalega (12):
  mmc: mmc header fix
  part: header fix
  arm:goni: Update configuration for goni target
  dfu: fix boards wo USB cable detection
  am335x: dfu: disable DFU in am335x_evm SPL build
  USB: gadget: added a saner gadget downloader registration API
  arm:goni:dfu Add support for DFU to Goni target
  arm:goni: enable GPT command
  arm:goni: enable USB Mass Storage
  dfu:mmc: raw data write fix
  mmc: postponed needless timer initialization
  ums: always initialize mmc before ums_disk_init()

 board/samsung/common/ums.c          |  12 ++--
 board/samsung/goni/goni.c           |   9 +++
 common/cmd_dfu.c                    |   3 +-
 common/cmd_thordown.c               |   3 +-
 common/cmd_usb_mass_storage.c       |   4 +-
 drivers/dfu/dfu_mmc.c               | 106 +++++++++++++++++++--------------
 drivers/mmc/mmc.c                   |   7 ++-
 drivers/usb/gadget/f_dfu.c          |  11 +++-
 drivers/usb/gadget/f_mass_storage.c |   6 ++
 drivers/usb/gadget/f_thor.c         |   5 ++
 drivers/usb/gadget/g_dnl.c          |  74 +++++++++++------------
 include/configs/am335x_evm.h        |  10 ++--
 include/configs/s5p_goni.h          | 113 +++++++++++++++++++++++++-----------
 include/configs/trats.h             |   2 +-
 include/configs/trats2.h            |   2 +-
 include/dfu.h                       |  12 ----
 include/g_dnl.h                     |  11 ++++
 include/mmc.h                       |   1 +
 include/part.h                      |   1 +
 include/thor.h                      |   8 ---
 include/usb_mass_storage.h          |   8 ---
 21 files changed, 239 insertions(+), 169 deletions(-)
Mateusz Zalega - March 31, 2014, 3:48 p.m.
This is an updated version of patch series regarding DFU, MMC, USB Gadget and
Samsung Goni board, originally sent on 10 January 2014.

---
Changes since v1:
- reordered
  "USB: gadget: added a saner gadget downloader registration API"
- fixed a bug related to usb_cable_connected() which broke previous Goni
  configuration patches
- disabled DFU in TI's am335x SPL build due to insufficient SRAM capacity
v2:
- fixed issues which came to [Marek Vasut]'s attention
- rebased
---

Mateusz Zalega (13):
  mmc: mmc header fix
  part: header fix
  arm:goni: Update configuration for goni target
  dfu: fix boards wo USB cable detection
  am335x: dfu: disable DFU in am335x_evm SPL build
  USB: gadget: added a saner gadget downloader registration API
  arm:goni:dfu Add support for DFU to Goni target
  arm:goni: enable GPT command
  arm:goni: enable USB Mass Storage
  dfu:mmc: raw data write fix
  mmc: postponed needless timer initialization
  ums: always initialize mmc before ums_disk_init()
  common: fixed linker-list example

 board/samsung/common/ums.c          |  12 ++--
 board/samsung/goni/goni.c           |   8 +++
 common/cmd_dfu.c                    |   3 +-
 common/cmd_thordown.c               |   3 +-
 common/cmd_usb_mass_storage.c       |   4 +-
 drivers/dfu/dfu_mmc.c               | 106 +++++++++++++++++++--------------
 drivers/mmc/mmc.c                   |   7 ++-
 drivers/usb/gadget/f_dfu.c          |   3 +
 drivers/usb/gadget/f_mass_storage.c |   3 +
 drivers/usb/gadget/f_thor.c         |   2 +
 drivers/usb/gadget/g_dnl.c          |  64 +++++++++-----------
 include/configs/am335x_evm.h        |  10 ++--
 include/configs/s5p_goni.h          | 113 +++++++++++++++++++++++++-----------
 include/configs/trats.h             |   2 +-
 include/configs/trats2.h            |   2 +-
 include/dfu.h                       |  12 ----
 include/g_dnl.h                     |  24 ++++++++
 include/linker_lists.h              |   2 +-
 include/mmc.h                       |   1 +
 include/part.h                      |   1 +
 include/thor.h                      |   8 ---
 include/usb_mass_storage.h          |   8 ---
 22 files changed, 236 insertions(+), 162 deletions(-)
Mateusz Zalega - April 15, 2014, 1:06 p.m.
This is, I hope, the final version of patchset.

Custodians: please ack appropriate patches.

Minkyu Kang: Could you pick it up after it gets reviewed by the community?

patches 1-7: fixes that can be applied before features
patches 8-13: features and fixes that depend on features

Patchset has been tested by running MAKEALL -a arm on every commit, so that it
wouldn't break bisect.

Cc: Minkyu Kang <mk7.kang@samsung.com>
Cc: Marek Vasut <marex@denx.de>
Cc: Tom Rini <trini@ti.com>
Cc: Lukasz Majewski <l.majewski@samsung.com>
Cc: Pantelis Antoniou <panto@antoniou-consulting.com>

---
Changes since v1:
- reordered
  "USB: gadget: added a saner gadget downloader registration API"
- fixed a bug related to usb_cable_connected() which broke previous Goni
  configuration patches
- disabled DFU in TI's am335x SPL build due to insufficient SRAM capacity
v2:
- fixed issues which came to [Marek Vasut]'s attention
- rebased
v3:
- previous version of the ums patch introduced "unused variable" warnings
- const attribute of function argument broke existing interface in one of MMC patches
- grouped patches related to common topics
---

Mateusz Zalega (13):
  mmc: mmc header fix
  part: header fix
  common: fixed linker-list example
  usb: dfu: fix boards wo USB cable detection
  mmc: postponed needless timer initialization
  dfu: mmc: raw data write fix
  ums: always initialize mmc before ums_disk_init()
  am335x: dfu: disable DFU in am335x_evm SPL build
  USB: gadget: added a saner gadget downloader registration API
  arm: goni: Update configuration for Goni target
  arm: goni: dfu: Add support for DFU to Goni target
  arm: goni: enable GPT command
  arm: goni: enable USB Mass Storage

 board/samsung/common/ums.c          |  10 ++--
 board/samsung/goni/goni.c           |   8 +++
 common/cmd_dfu.c                    |   3 +-
 common/cmd_thordown.c               |   3 +-
 common/cmd_usb_mass_storage.c       |   4 +-
 drivers/dfu/dfu_mmc.c               | 106 +++++++++++++++++++--------------
 drivers/mmc/mmc.c                   |   7 ++-
 drivers/usb/gadget/f_dfu.c          |   3 +
 drivers/usb/gadget/f_mass_storage.c |   3 +
 drivers/usb/gadget/f_thor.c         |   2 +
 drivers/usb/gadget/g_dnl.c          |  64 +++++++++-----------
 include/configs/am335x_evm.h        |  10 ++--
 include/configs/s5p_goni.h          | 113 +++++++++++++++++++++++++-----------
 include/configs/trats.h             |   2 +-
 include/configs/trats2.h            |   2 +-
 include/dfu.h                       |  12 ----
 include/g_dnl.h                     |  24 ++++++++
 include/linker_lists.h              |   2 +-
 include/mmc.h                       |   1 +
 include/part.h                      |   1 +
 include/thor.h                      |   8 ---
 include/usb_mass_storage.h          |   8 ---
 22 files changed, 235 insertions(+), 161 deletions(-)

Patch

diff --git a/include/mmc.h b/include/mmc.h
index cb558da..e490a06 100644
--- a/include/mmc.h
+++ b/include/mmc.h
@@ -12,6 +12,7 @@ 
 
 #include <linux/list.h>
 #include <linux/compiler.h>
+#include <part.h>
 
 #define SD_VERSION_SD	0x20000
 #define SD_VERSION_3	(SD_VERSION_SD | 0x300)