Patchwork [v2,14/28] drm/i2c: tda998x: get a better status of the connexion

login
register
mail settings
Submitter Jean-Francois Moine
Date Jan. 9, 2014, 11:04 a.m.
Message ID <20140109120428.1ea7ec3a@armhf>
Download mbox | patch
Permalink /patch/308607/
State New
Headers show

Comments

Jean-Francois Moine - Jan. 9, 2014, 11:04 a.m.
This patch refines the connexion status testing both bits RXSENS and
HPD of the CEC register giving the connexion level.

Signed-off-by: Jean-Francois Moine <moinejf@free.fr>
---
 drivers/gpu/drm/i2c/tda998x_drv.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Russell King - ARM Linux - Jan. 11, 2014, 6:15 p.m.
On Thu, Jan 09, 2014 at 12:04:28PM +0100, Jean-Francois Moine wrote:
> This patch refines the connexion status testing both bits RXSENS and
> HPD of the CEC register giving the connexion level.

In English, it's spelt "connection" - there is no x, despite it sounding
like there is.

Patch

diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c
index 2187d63..0cae820 100644
--- a/drivers/gpu/drm/i2c/tda998x_drv.c
+++ b/drivers/gpu/drm/i2c/tda998x_drv.c
@@ -1009,7 +1009,9 @@  tda998x_encoder_detect(struct drm_encoder *encoder,
 	struct tda998x_priv *priv = to_tda998x_priv(encoder);
 	uint8_t val = cec_read(priv, REG_CEC_RXSHPDLEV);
 
-	return (val & CEC_RXSHPDLEV_HPD) ? connector_status_connected :
+	return (val & (CEC_RXSHPDLEV_RXSENS | CEC_RXSHPDLEV_HPD)) ==
+				(CEC_RXSHPDLEV_RXSENS | CEC_RXSHPDLEV_HPD) ?
+			connector_status_connected :
 			connector_status_disconnected;
 }