| Message ID | 1249569709-21403-5-git-send-email-anemo@mba.ocn.ne.jp |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp> Date: Thu, 6 Aug 2009 23:41:49 +0900 > The datasheet say "When not enabling packing, the MinFrag value must > remain at 0". Do not set value to RxFragSize register if > TC35815_USE_PACKEDBUFFER disabled. > > This is not a bugfix. No real problem reported on this. > > Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp> Applied to net-next-2.6 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/tc35815.c b/drivers/net/tc35815.c index 564d555..d2ca47f 100644 --- a/drivers/net/tc35815.c +++ b/drivers/net/tc35815.c @@ -2394,8 +2394,6 @@ static void tc35815_chip_init(struct net_device *dev) tc_writel(DMA_BURST_SIZE, &tr->DMA_Ctl); #ifdef TC35815_USE_PACKEDBUFFER tc_writel(RxFrag_EnPack | ETH_ZLEN, &tr->RxFragSize); /* Packing */ -#else - tc_writel(ETH_ZLEN, &tr->RxFragSize); #endif tc_writel(0, &tr->TxPollCtr); /* Batch mode */ tc_writel(TX_THRESHOLD, &tr->TxThrsh);
The datasheet say "When not enabling packing, the MinFrag value must remain at 0". Do not set value to RxFragSize register if TC35815_USE_PACKEDBUFFER disabled. This is not a bugfix. No real problem reported on this. Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp> --- drivers/net/tc35815.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)