| Message ID | 1389211538-23364-1-git-send-email-loic@dachary.org |
|---|---|
| State | New |
| Headers | show |
On 01/08/2014 12:05 PM, Loic Dachary wrote: > Suppress rbd progress messages with --no-progress so they are not > confused with an error output when comparing test results ( progress is > displayed on stderr ). > > Signed-off-by: Loic Dachary <loic@dachary.org> > --- > tests/qemu-iotests/common.rc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc > index 28ba0d9..7442bad 100644 > --- a/tests/qemu-iotests/common.rc > +++ b/tests/qemu-iotests/common.rc > @@ -189,7 +189,7 @@ _cleanup_test_img() > ;; > > rbd) > - rbd rm "$TEST_DIR/t.$IMGFMT" > /dev/null > + rbd --no-progress rm "$TEST_DIR/t.$IMGFMT" > /dev/null > ;; > > sheepdog) > This flag was added in ceph 0.61. I doubt anyone is interested in running these tests against earlier versions of ceph (the current stable releases are 0.67 and 0.72). Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
On Wed, Jan 08, 2014 at 09:05:38PM +0100, Loic Dachary wrote: > Suppress rbd progress messages with --no-progress so they are not > confused with an error output when comparing test results ( progress is > displayed on stderr ). > > Signed-off-by: Loic Dachary <loic@dachary.org> > --- > tests/qemu-iotests/common.rc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks! Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
The Thursday 09 Jan 2014 à 09:45:14 (+0800), Stefan Hajnoczi wrote : > On Wed, Jan 08, 2014 at 09:05:38PM +0100, Loic Dachary wrote: > > Suppress rbd progress messages with --no-progress so they are not > > confused with an error output when comparing test results ( progress is > > displayed on stderr ). > > > > Signed-off-by: Loic Dachary <loic@dachary.org> > > --- > > tests/qemu-iotests/common.rc | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Thanks! > > Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> > Should this be merged before 2.0 ? Best regards Benoît
On Wed, Jan 08, 2014 at 09:05:38PM +0100, Loic Dachary wrote: > Suppress rbd progress messages with --no-progress so they are not > confused with an error output when comparing test results ( progress is > displayed on stderr ). > > Signed-off-by: Loic Dachary <loic@dachary.org> > --- > tests/qemu-iotests/common.rc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan
diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc index 28ba0d9..7442bad 100644 --- a/tests/qemu-iotests/common.rc +++ b/tests/qemu-iotests/common.rc @@ -189,7 +189,7 @@ _cleanup_test_img() ;; rbd) - rbd rm "$TEST_DIR/t.$IMGFMT" > /dev/null + rbd --no-progress rm "$TEST_DIR/t.$IMGFMT" > /dev/null ;; sheepdog)
Suppress rbd progress messages with --no-progress so they are not confused with an error output when comparing test results ( progress is displayed on stderr ). Signed-off-by: Loic Dachary <loic@dachary.org> --- tests/qemu-iotests/common.rc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)