Patchwork [v3] ARM: imx: add select on ARCH_MXC for cpufreq support

login
register
mail settings
Submitter John Tobias
Date Jan. 8, 2014, 7:56 p.m.
Message ID <1389210991-23688-1-git-send-email-john.tobias.ph@gmail.com>
Download mbox | patch
Permalink /patch/308417/
State New
Headers show

Comments

John Tobias - Jan. 8, 2014, 7:56 p.m.
Moved ARCH_HAS_CPUFREQ, HAVE_IMX_ANATOP and PM_OPP on ARCH_MXC so that
the user can enable the cpufreq support for iMX6Q and/or iMX6SL.

Signed-off-by: John Tobias <john.tobias.ph@gmail.com>
---
 arch/arm/mach-imx/Kconfig | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)
Fabio Estevam - Jan. 8, 2014, 8 p.m.
Hi John,

On Wed, Jan 8, 2014 at 5:56 PM, John Tobias <john.tobias.ph@gmail.com> wrote:
> Moved ARCH_HAS_CPUFREQ, HAVE_IMX_ANATOP and PM_OPP on ARCH_MXC so that
> the user can enable the cpufreq support for iMX6Q and/or iMX6SL.
>
> Signed-off-by: John Tobias <john.tobias.ph@gmail.com>
> ---
>  arch/arm/mach-imx/Kconfig | 13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
> index 7a6e6f7..3c326be 100644
> --- a/arch/arm/mach-imx/Kconfig
> +++ b/arch/arm/mach-imx/Kconfig
> @@ -1,5 +1,6 @@
>  config ARCH_MXC
>         bool "Freescale i.MX family" if ARCH_MULTI_V4_V5 || ARCH_MULTI_V6_V7
> +       select ARCH_HAS_CPUFREQ
>         select ARCH_REQUIRE_GPIOLIB
>         select ARM_CPU_SUSPEND if PM
>         select ARM_PATCH_PHYS_VIRT
> @@ -9,8 +10,10 @@ config ARCH_MXC
>         select GENERIC_ALLOCATOR
>         select GENERIC_CLOCKEVENTS
>         select GENERIC_IRQ_CHIP
> +       select HAVE_IMX_ANATOP

This option is for mx6 only, so better not put it inside ARCH_MXC.

Regards,

Fabio Estevam
Alexander Shiyan - Jan. 8, 2014, 8:03 p.m.
Hello.

Среда,  8 января 2014, 11:56 -08:00 от John Tobias <john.tobias.ph@gmail.com>:
> Moved ARCH_HAS_CPUFREQ, HAVE_IMX_ANATOP and PM_OPP on ARCH_MXC so that
> the user can enable the cpufreq support for iMX6Q and/or iMX6SL.
> 
> Signed-off-by: John Tobias <john.tobias.ph@gmail.com>
> ---
>  arch/arm/mach-imx/Kconfig | 13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)
> 
> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
> index 7a6e6f7..3c326be 100644
> --- a/arch/arm/mach-imx/Kconfig
> +++ b/arch/arm/mach-imx/Kconfig
> @@ -1,5 +1,6 @@
>  config ARCH_MXC
>  	bool "Freescale i.MX family" if ARCH_MULTI_V4_V5 || ARCH_MULTI_V6_V7
> +	select ARCH_HAS_CPUFREQ
>  	select ARCH_REQUIRE_GPIOLIB
>  	select ARM_CPU_SUSPEND if PM
>  	select ARM_PATCH_PHYS_VIRT
> @@ -9,8 +10,10 @@ config ARCH_MXC
>  	select GENERIC_ALLOCATOR
>  	select GENERIC_CLOCKEVENTS
>  	select GENERIC_IRQ_CHIP
> +	select HAVE_IMX_ANATOP

Maybe better:
select HAVE_IMX_ANATOP if ARCH_MULTI_V6_V7

---
John Tobias - Jan. 8, 2014, 8:24 p.m.
thanks for the info. Will fix it.

On Wed, Jan 8, 2014 at 12:03 PM, Alexander Shiyan <shc_work@mail.ru> wrote:
> Hello.
>
> Среда,  8 января 2014, 11:56 -08:00 от John Tobias <john.tobias.ph@gmail.com>:
>> Moved ARCH_HAS_CPUFREQ, HAVE_IMX_ANATOP and PM_OPP on ARCH_MXC so that
>> the user can enable the cpufreq support for iMX6Q and/or iMX6SL.
>>
>> Signed-off-by: John Tobias <john.tobias.ph@gmail.com>
>> ---
>>  arch/arm/mach-imx/Kconfig | 13 ++++++-------
>>  1 file changed, 6 insertions(+), 7 deletions(-)
>>
>> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
>> index 7a6e6f7..3c326be 100644
>> --- a/arch/arm/mach-imx/Kconfig
>> +++ b/arch/arm/mach-imx/Kconfig
>> @@ -1,5 +1,6 @@
>>  config ARCH_MXC
>>       bool "Freescale i.MX family" if ARCH_MULTI_V4_V5 || ARCH_MULTI_V6_V7
>> +     select ARCH_HAS_CPUFREQ
>>       select ARCH_REQUIRE_GPIOLIB
>>       select ARM_CPU_SUSPEND if PM
>>       select ARM_PATCH_PHYS_VIRT
>> @@ -9,8 +10,10 @@ config ARCH_MXC
>>       select GENERIC_ALLOCATOR
>>       select GENERIC_CLOCKEVENTS
>>       select GENERIC_IRQ_CHIP
>> +     select HAVE_IMX_ANATOP
>
> Maybe better:
> select HAVE_IMX_ANATOP if ARCH_MULTI_V6_V7
>
> ---
Fabio Estevam - Jan. 8, 2014, 8:33 p.m.
On Wed, Jan 8, 2014 at 6:03 PM, Alexander Shiyan <shc_work@mail.ru> wrote:

> Maybe better:
> select HAVE_IMX_ANATOP if ARCH_MULTI_V6_V7

mx31, mx35, mx51 and mx53 do not have this ANATOP block.

Regards,

Fabio Estevam
John Tobias - Jan. 8, 2014, 8:45 p.m.
Hi Fabio,

How about select HAVE_IMX_ANATOP if SOC_IMX6Q || SOC_IMX6SL

Regards,

john

On Wed, Jan 8, 2014 at 12:33 PM, Fabio Estevam <festevam@gmail.com> wrote:
> On Wed, Jan 8, 2014 at 6:03 PM, Alexander Shiyan <shc_work@mail.ru> wrote:
>
>> Maybe better:
>> select HAVE_IMX_ANATOP if ARCH_MULTI_V6_V7
>
> mx31, mx35, mx51 and mx53 do not have this ANATOP block.
>
> Regards,
>
> Fabio Estevam
John Tobias - Jan. 8, 2014, 8:55 p.m.
I recompiled the kernel using the said config and it works. But, if
you have any other suggestion it would be great.

Regards,

john

On Wed, Jan 8, 2014 at 12:45 PM, John Tobias <john.tobias.ph@gmail.com> wrote:
> Hi Fabio,
>
> How about select HAVE_IMX_ANATOP if SOC_IMX6Q || SOC_IMX6SL
>
> Regards,
>
> john
>
> On Wed, Jan 8, 2014 at 12:33 PM, Fabio Estevam <festevam@gmail.com> wrote:
>> On Wed, Jan 8, 2014 at 6:03 PM, Alexander Shiyan <shc_work@mail.ru> wrote:
>>
>>> Maybe better:
>>> select HAVE_IMX_ANATOP if ARCH_MULTI_V6_V7
>>
>> mx31, mx35, mx51 and mx53 do not have this ANATOP block.
>>
>> Regards,
>>
>> Fabio Estevam

Patch

diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
index 7a6e6f7..3c326be 100644
--- a/arch/arm/mach-imx/Kconfig
+++ b/arch/arm/mach-imx/Kconfig
@@ -1,5 +1,6 @@ 
 config ARCH_MXC
 	bool "Freescale i.MX family" if ARCH_MULTI_V4_V5 || ARCH_MULTI_V6_V7
+	select ARCH_HAS_CPUFREQ
 	select ARCH_REQUIRE_GPIOLIB
 	select ARM_CPU_SUSPEND if PM
 	select ARM_PATCH_PHYS_VIRT
@@ -9,8 +10,10 @@  config ARCH_MXC
 	select GENERIC_ALLOCATOR
 	select GENERIC_CLOCKEVENTS
 	select GENERIC_IRQ_CHIP
+	select HAVE_IMX_ANATOP
 	select MIGHT_HAVE_CACHE_L2X0 if ARCH_MULTI_V6_V7
 	select MULTI_IRQ_HANDLER
+	select PM_OPP if PM
 	select SOC_BUS
 	select SPARSE_IRQ
 	select USE_OF
@@ -779,16 +782,14 @@  config	SOC_IMX53
 
 config SOC_IMX6Q
 	bool "i.MX6 Quad/DualLite support"
-	select ARCH_HAS_CPUFREQ
-	select ARCH_HAS_OPP
+	select ARCH_HAS_OPP	
 	select ARM_ERRATA_754322
 	select ARM_ERRATA_764369 if SMP
 	select ARM_ERRATA_775420
 	select ARM_GIC
 	select CPU_V7
 	select HAVE_ARM_SCU if SMP
-	select HAVE_ARM_TWD if SMP
-	select HAVE_IMX_ANATOP
+	select HAVE_ARM_TWD if SMP	
 	select HAVE_IMX_GPC
 	select HAVE_IMX_MMDC
 	select HAVE_IMX_SRC
@@ -800,8 +801,7 @@  config SOC_IMX6Q
 	select PINCTRL_IMX6Q
 	select PL310_ERRATA_588369 if CACHE_PL310
 	select PL310_ERRATA_727915 if CACHE_PL310
-	select PL310_ERRATA_769419 if CACHE_PL310
-	select PM_OPP if PM
+	select PL310_ERRATA_769419 if CACHE_PL310	
 
 	help
 	  This enables support for Freescale i.MX6 Quad processor.
@@ -812,7 +812,6 @@  config SOC_IMX6SL
 	select ARM_ERRATA_775420
 	select ARM_GIC
 	select CPU_V7
-	select HAVE_IMX_ANATOP
 	select HAVE_IMX_GPC
 	select HAVE_IMX_MMDC
 	select HAVE_IMX_SRC