Message ID | 1389202297.23721.33.camel@hornet |
---|---|
State | New |
Headers | show |
On Wed, Jan 08, 2014 at 05:31:37PM +0000, Pawel Moll wrote: > On Tue, 2013-12-24 at 12:19 +0000, Mark Brown wrote: > > No, we need to find a better way of doing this such as checking to see > > if register zero is accessible in some way. We want to avoid having > > those files if there's no way of populating them since this is useful > > information for tooling. > Something like this then? > diff --git a/drivers/base/regmap/regmap-debugfs.c b/drivers/base/regmap/regmap-debugfs.c > index c5471cd..45d812c 100644 > --- a/drivers/base/regmap/regmap-debugfs.c > +++ b/drivers/base/regmap/regmap-debugfs.c > @@ -511,7 +511,7 @@ void regmap_debugfs_init(struct regmap *map, const char *name) > debugfs_create_file("range", 0400, map->debugfs, > map, ®map_reg_ranges_fops); > > - if (map->max_register) { > + if (map->max_register || regmap_readable(map, 0)) { Yes.
diff --git a/drivers/base/regmap/regmap-debugfs.c b/drivers/base/regmap/regmap-debugfs.c index c5471cd..45d812c 100644 --- a/drivers/base/regmap/regmap-debugfs.c +++ b/drivers/base/regmap/regmap-debugfs.c @@ -511,7 +511,7 @@ void regmap_debugfs_init(struct regmap *map, const char *name) debugfs_create_file("range", 0400, map->debugfs, map, ®map_reg_ranges_fops); - if (map->max_register) { + if (map->max_register || regmap_readable(map, 0)) { debugfs_create_file("registers", 0400, map->debugfs, map, ®map_map_fops); debugfs_create_file("access", 0400, map->debugfs,