diff mbox

[v2] ARM: imx: select ARCH_HAS_CPUFREQ for iMX6SL

Message ID 1389148163-5243-1-git-send-email-john.tobias.ph@gmail.com
State New
Headers show

Commit Message

John Tobias Jan. 8, 2014, 2:29 a.m. UTC
iMX6SL now supports the cpufreq scaling by re-using the imx6q-cpufreq driver.
By adding it, the user has the capability to select the said driver without
depending it to SOC_IMX6Q.

Signed-off-by: John Tobias <john.tobias.ph@gmail.com>
---
Changes since v1:
- Fix typo in commit log
- Added Shawn Guo on Cc

 arch/arm/mach-imx/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Shawn Guo Jan. 8, 2014, 2:40 p.m. UTC | #1
On Tue, Jan 07, 2014 at 06:29:23PM -0800, John Tobias wrote:
> iMX6SL now supports the cpufreq scaling by re-using the imx6q-cpufreq driver.
> By adding it, the user has the capability to select the said driver without
> depending it to SOC_IMX6Q.
> 
> Signed-off-by: John Tobias <john.tobias.ph@gmail.com>
> ---
> Changes since v1:
> - Fix typo in commit log
> - Added Shawn Guo on Cc
> 
>  arch/arm/mach-imx/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
> index 7a6e6f7..704e5ae 100644
> --- a/arch/arm/mach-imx/Kconfig
> +++ b/arch/arm/mach-imx/Kconfig
> @@ -808,6 +808,7 @@ config SOC_IMX6Q
>  
>  config SOC_IMX6SL
>  	bool "i.MX6 SoloLite support"
> +	select ARCH_HAS_CPUFREQ

Since we will eventually enable CPUFREQ and OPP for most of the
platforms, maybe we should just move selection of ARCH_HAS_CPUFREQ,
ARCH_HAS_OPP and PM_OPP into 'config ARCH_MXC'?

Shawn

>  	select ARM_ERRATA_754322
>  	select ARM_ERRATA_775420
>  	select ARM_GIC
> -- 
> 1.8.3.2
>
John Tobias Jan. 8, 2014, 6:38 p.m. UTC | #2
That's fine with me. We can save two lines in the file.

> On Jan 8, 2014, at 6:40 AM, Shawn Guo <shawn.guo@linaro.org> wrote:
>
>> On Tue, Jan 07, 2014 at 06:29:23PM -0800, John Tobias wrote:
>> iMX6SL now supports the cpufreq scaling by re-using the imx6q-cpufreq driver.
>> By adding it, the user has the capability to select the said driver without
>> depending it to SOC_IMX6Q.
>>
>> Signed-off-by: John Tobias <john.tobias.ph@gmail.com>
>> ---
>> Changes since v1:
>> - Fix typo in commit log
>> - Added Shawn Guo on Cc
>>
>> arch/arm/mach-imx/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
>> index 7a6e6f7..704e5ae 100644
>> --- a/arch/arm/mach-imx/Kconfig
>> +++ b/arch/arm/mach-imx/Kconfig
>> @@ -808,6 +808,7 @@ config SOC_IMX6Q
>>
>> config SOC_IMX6SL
>>    bool "i.MX6 SoloLite support"
>> +    select ARCH_HAS_CPUFREQ
>
> Since we will eventually enable CPUFREQ and OPP for most of the
> platforms, maybe we should just move selection of ARCH_HAS_CPUFREQ,
> ARCH_HAS_OPP and PM_OPP into 'config ARCH_MXC'?
>
> Shawn
>
>>    select ARM_ERRATA_754322
>>    select ARM_ERRATA_775420
>>    select ARM_GIC
>> --
>> 1.8.3.2
>
diff mbox

Patch

diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
index 7a6e6f7..704e5ae 100644
--- a/arch/arm/mach-imx/Kconfig
+++ b/arch/arm/mach-imx/Kconfig
@@ -808,6 +808,7 @@  config SOC_IMX6Q
 
 config SOC_IMX6SL
 	bool "i.MX6 SoloLite support"
+	select ARCH_HAS_CPUFREQ
 	select ARM_ERRATA_754322
 	select ARM_ERRATA_775420
 	select ARM_GIC