From patchwork Tue Jan 7 18:27:25 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 307735 Return-Path: X-Original-To: incoming-imx@patchwork.ozlabs.org Delivered-To: patchwork-incoming-imx@bilbo.ozlabs.org Received: from casper.infradead.org (unknown [IPv6:2001:770:15f::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 5D8B32C00E1 for ; Wed, 8 Jan 2014 05:28:14 +1100 (EST) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1W0bNm-0000yz-0X; Tue, 07 Jan 2014 18:28:06 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1W0bNj-0007yR-GX; Tue, 07 Jan 2014 18:28:03 +0000 Received: from mail-wg0-f49.google.com ([74.125.82.49]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1W0bNg-0007x4-ON for linux-arm-kernel@lists.infradead.org; Tue, 07 Jan 2014 18:28:01 +0000 Received: by mail-wg0-f49.google.com with SMTP id x12so495629wgg.4 for ; Tue, 07 Jan 2014 10:27:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-type:content-transfer-encoding; bh=8Gy7rwPrrmkfUb8PYbeLz8e7vAyKGnyZCxENQP8WtVk=; b=LQrR0OilTkoPYE99Pb13TKDkCYiEXNJtZdalMvkbdgnn4YQEWA0TfsV6YGjm0UcrDR cBqGAlvQdyvcoby1D0HIqPt5hshIgOb1RLEo9sc39VQkGkTf5POoNR8AJixGcSzqHJ3j 0x8QRP1t+eFyGiM6j+iGT8Zd2aprILtAW9xR4ibea+3My4oN5EgHA8zpaRnGQcqXAp+i QR9OMIbK4renyKD77M1JsLN1ajKq3BZ7+pI8+mGlc07evSIiEKKQah7ZCvnHulU9efTd dvoPEph9+17fkOlqYL1A29Kt8gZ5adZEa88GdPUv683L5/LdUS53k33/0KHxugFTpfmZ ZNFQ== X-Gm-Message-State: ALoCoQn6NY+ovtruXqpbl4qrUoz64+C5IpJkpSrN0Bt66et8TkHzhvbrAN24Pt9RhUhtct9k1ldf X-Received: by 10.195.13.234 with SMTP id fb10mr9210295wjd.50.1389119255847; Tue, 07 Jan 2014 10:27:35 -0800 (PST) Received: from localhost.localdomain ([85.235.11.236]) by mx.google.com with ESMTPSA id po3sm46086711wjc.3.2014.01.07.10.27.33 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Jan 2014 10:27:34 -0800 (PST) From: Linus Walleij To: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Kukjin Kim , Ben Dooks Subject: [PATCH] ARM: s3c24xx: fix build error Date: Tue, 7 Jan 2014 19:27:25 +0100 Message-Id: <1389119245-2167-1-git-send-email-linus.walleij@linaro.org> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140107_132800_908943_948291D5 X-CRM114-Status: GOOD ( 12.46 ) X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [74.125.82.49 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Linus Walleij , Sylwester Nawrocki , Heiko Stuebner , Tomasz Figa X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org List-Id: linux-imx-kernel.lists.patchwork.ozlabs.org When enabling device tree on the S3C an additional build bug appears in the Osiris DVS board file: CC arch/arm/mach-s3c24xx/mach-osiris-dvs.o archh/arm/mach-s3c24xx/mach-osiris-dvs.c: In function ‘osiris_dvs_notify’: arch/arm/mach-s3c24xx/mach-osiris-dvs.c:77:4: error: implicit declaration of function ‘S3C2410_GPB’ [-Werror=implicit-function-declaration] gpio_set_value(OSIRIS_GPIO_DVS, 1); ^ Fix this by explicitly including Reported-by: Arnd Bergmann Cc: Kukjin Kim Cc: Heiko Stuebner Cc: Tomasz Figa Cc: Sylwester Nawrocki Cc: Ben Dooks Cc: linux-samsung-soc@vger.kernel.org Signed-off-by: Linus Walleij Acked-by: Heiko Stuebner --- I have tentatively applied this to the GPIO tree so I don't cause build regressions, ACKs are still appreciated from the S3C maintainers. --- arch/arm/mach-s3c24xx/mach-osiris-dvs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-s3c24xx/mach-osiris-dvs.c b/arch/arm/mach-s3c24xx/mach-osiris-dvs.c index 45e74363aaa9..5b8af46c0d6b 100644 --- a/arch/arm/mach-s3c24xx/mach-osiris-dvs.c +++ b/arch/arm/mach-s3c24xx/mach-osiris-dvs.c @@ -16,6 +16,7 @@ #include #include #include +#include #include