[08/10] debugfs: remove dead code

Addresses-Coverity-Id: #1138573

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
---
 debugfs/debugfs.c | 2 --
 1 file changed, 2 deletions(-)

On 1/7/14, 8:53 AM, Theodore Ts'o wrote:
> Addresses-Coverity-Id: #1138573
> 
> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>

Reviewed-by: Eric Sandeen <sandeen@redhat.com>

FWIW, Darrick had already sent this as part of

"[PATCH 1/2] misc: fix resource leaks in e2fsprogs"

- but I suppose small targeted patches are better.

-Eric

> ---
>  debugfs/debugfs.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/debugfs/debugfs.c b/debugfs/debugfs.c
> index 998af33..0e56ead 100644
> --- a/debugfs/debugfs.c
> +++ b/debugfs/debugfs.c
> @@ -289,8 +289,6 @@ void do_init_filesys(int argc, char **argv)
>  	if (err)
>  		return;
>  	ext2fs_blocks_count_set(&param, blocks);
> -	if (err)
> -		return;
>  	retval = ext2fs_initialize(argv[1], 0, &param,
>  				   unix_io_manager, &current_fs);
>  	if (retval) {
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

On Tue, Jan 07, 2014 at 11:14:39AM -0600, Eric Sandeen wrote:
> 
> Reviewed-by: Eric Sandeen <sandeen@redhat.com>
> 
> FWIW, Darrick had already sent this as part of
> 
> "[PATCH 1/2] misc: fix resource leaks in e2fsprogs"
> 
> - but I suppose small targeted patches are better.

Whoops, I somehow managed to lose this patch in my inbox.  I see it in
patchwork, though.  I'll have to double check which of the other fixes
in his patch are still needed.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

On Tue, Jan 07, 2014 at 12:25:48PM -0500, Theodore Ts'o wrote:
> On Tue, Jan 07, 2014 at 11:14:39AM -0600, Eric Sandeen wrote:
> > 
> > Reviewed-by: Eric Sandeen <sandeen@redhat.com>
> > 
> > FWIW, Darrick had already sent this as part of
> > 
> > "[PATCH 1/2] misc: fix resource leaks in e2fsprogs"
> > 
> > - but I suppose small targeted patches are better.
> 
> Whoops, I somehow managed to lose this patch in my inbox.  I see it in
> patchwork, though.  I'll have to double check which of the other fixes
> in his patch are still needed.

As far as coverity bugs go, I put my name on all the bugs that I fixed, and
left the rest alone.

--D
> 
> 						- Ted
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html