Patchwork Soften up the dmesg on SB600 PMP softreset failure recovery

login
register
mail settings
Submitter Shane Huang
Date Aug. 5, 2009, 2:10 a.m.
Message ID <1249438241.3583.5.camel@zm-desktop>
Download mbox | patch
Permalink /patch/30762/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Shane Huang - Aug. 5, 2009, 2:10 a.m.
Too strong words led to spurious bug reports: Novell bugzilla #527748,
RedHat bugzilla #468800. This patch is used to soften up the dmesg on
SB600 PMP softreset failure recovery, so as to remove the scariness and
concern from community.

Reported-by: pgnet Dev <pgnet.dev@gmail.com>
Signed-off-by: Shane Huang <shane.huang@amd.com>
Cc: Tejun Heo <tj@kernel.org>



--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Tejun Heo - Aug. 5, 2009, 2:20 a.m.
Shane Huang wrote:
> Too strong words led to spurious bug reports: Novell bugzilla #527748,
> RedHat bugzilla #468800. This patch is used to soften up the dmesg on
> SB600 PMP softreset failure recovery, so as to remove the scariness and
> concern from community.
> 
> Reported-by: pgnet Dev <pgnet.dev@gmail.com>
> Signed-off-by: Shane Huang <shane.huang@amd.com>
> Cc: Tejun Heo <tj@kernel.org>

Acked-by: Tejun Heo <tj@kernel.org>
Jeff Garzik - Aug. 12, 2009, 10:26 a.m.
Shane Huang wrote:
> Too strong words led to spurious bug reports: Novell bugzilla #527748,
> RedHat bugzilla #468800. This patch is used to soften up the dmesg on
> SB600 PMP softreset failure recovery, so as to remove the scariness and
> concern from community.
> 
> Reported-by: pgnet Dev <pgnet.dev@gmail.com>
> Signed-off-by: Shane Huang <shane.huang@amd.com>
> Cc: Tejun Heo <tj@kernel.org>
> 
> diff -ruN a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> --- a/drivers/ata/ahci.c	2009-07-29 14:38:39.000000000 +0800
> +++ b/drivers/ata/ahci.c	2009-08-04 17:24:34.000000000 +0800
> @@ -1769,7 +1769,8 @@
>  		irq_sts = readl(port_mmio + PORT_IRQ_STAT);
>  		if (irq_sts & PORT_IRQ_BAD_PMP) {
>  			ata_link_printk(link, KERN_WARNING,
> -					"failed due to HW bug, retry pmp=0\n");
> +					"applying SB600 PMP SRST workaround "
> +					"and retrying\n");
>  			rc = ahci_do_softreset(link, class, 0, deadline,
>  					       ahci_check_ready);

applied


--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff -ruN a/drivers/ata/ahci.c b/drivers/ata/ahci.c
--- a/drivers/ata/ahci.c	2009-07-29 14:38:39.000000000 +0800
+++ b/drivers/ata/ahci.c	2009-08-04 17:24:34.000000000 +0800
@@ -1769,7 +1769,8 @@ 
 		irq_sts = readl(port_mmio + PORT_IRQ_STAT);
 		if (irq_sts & PORT_IRQ_BAD_PMP) {
 			ata_link_printk(link, KERN_WARNING,
-					"failed due to HW bug, retry pmp=0\n");
+					"applying SB600 PMP SRST workaround "
+					"and retrying\n");
 			rc = ahci_do_softreset(link, class, 0, deadline,
 					       ahci_check_ready);
 		}