| Message ID | 1389043097-30018-1-git-send-email-mlweber1@rockwellcollins.com |
|---|---|
| State | Superseded |
| Headers | show |
Dear Matt Weber, On Mon, 6 Jan 2014 15:18:17 -0600, Matt Weber wrote: > diff --git a/package/python-posix-ipc/Config.in b/package/python-posix-ipc/Config.in > new file mode 100644 > index 0000000..2fbc7a7 > --- /dev/null > +++ b/package/python-posix-ipc/Config.in > @@ -0,0 +1,10 @@ > +config BR2_PACKAGE_PYTHON_POSIX_IPC > + bool "python-posix-ipc" > + depends on BR2_PACKAGE_PYTHON I see #include <pthread.h> in the C code of the module, so maybe this Python module should depend on BR2_TOOLCHAIN_HAS_THREADS? > +PYTHON_POSIX_IPC_VERSION = 0.9.6 > +PYTHON_POSIX_IPC_SOURCE = posix_ipc-$(PYTHON_POSIX_IPC_VERSION).tar.gz > +PYTHON_POSIX_IPC_SITE = http://semanchuk.com/philip/posix_ipc/ > +PYTHON_POSIX_IPC_LICENSE = BSD-2c License is BSD-3c, not BSD-2c. > +PYTHON_POSIX_IPC_LICENSE_FILES = LICENSE > +PYTHON_POSIX_IPC_SETUP_TYPE = distutils Other than that, looks good to me (but I haven't tested). Thanks! Thomas
Hi Thomas, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote on 01/07/2014 12:17:23 AM: > From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > To: Matt Weber <mlweber1@rockwellcollins.com> > Cc: buildroot@busybox.net > Date: 01/07/2014 12:17 AM > Subject: Re: [Buildroot] [PATCH 1/1] python-posix-ipc: new package > > Dear Matt Weber, > > On Mon, 6 Jan 2014 15:18:17 -0600, Matt Weber wrote: > > > diff --git a/package/python-posix-ipc/Config.in b/package/python- > posix-ipc/Config.in > > new file mode 100644 > > index 0000000..2fbc7a7 > > --- /dev/null > > +++ b/package/python-posix-ipc/Config.in > > @@ -0,0 +1,10 @@ > > +config BR2_PACKAGE_PYTHON_POSIX_IPC > > + bool "python-posix-ipc" > > + depends on BR2_PACKAGE_PYTHON > > I see #include <pthread.h> in the C code of the module, so maybe this > Python module should depend on BR2_TOOLCHAIN_HAS_THREADS? Good catch, that would make sense as it's using mutex and lock functionality. > > > +PYTHON_POSIX_IPC_VERSION = 0.9.6 > > +PYTHON_POSIX_IPC_SOURCE = posix_ipc-$(PYTHON_POSIX_IPC_VERSION).tar.gz > > +PYTHON_POSIX_IPC_SITE = http://semanchuk.com/philip/posix_ipc/ > > +PYTHON_POSIX_IPC_LICENSE = BSD-2c > > License is BSD-3c, not BSD-2c. Ok, he had the link to the BSD-2c ( http://opensource.org/licenses/bsd-license.php) on his website. However since the source actually had BSD-3c and is more restrictive, I'll update to that. > > > +PYTHON_POSIX_IPC_LICENSE_FILES = LICENSE > > +PYTHON_POSIX_IPC_SETUP_TYPE = distutils > > Other than that, looks good to me (but I haven't tested). Thanks! Matt Weber mlweber1@rockwellcollins.com
diff --git a/package/Config.in b/package/Config.in index e502cde..501bd3d 100644 --- a/package/Config.in +++ b/package/Config.in @@ -406,6 +406,7 @@ source "package/python-meld3/Config.in" source "package/python-msgpack/Config.in" source "package/python-netifaces/Config.in" source "package/python-nfc/Config.in" +source "package/python-posix-ipc/Config.in" source "package/python-protobuf/Config.in" source "package/python-pyasn/Config.in" source "package/python-pycrypto/Config.in" diff --git a/package/python-posix-ipc/Config.in b/package/python-posix-ipc/Config.in new file mode 100644 index 0000000..2fbc7a7 --- /dev/null +++ b/package/python-posix-ipc/Config.in @@ -0,0 +1,10 @@ +config BR2_PACKAGE_PYTHON_POSIX_IPC + bool "python-posix-ipc" + depends on BR2_PACKAGE_PYTHON + help + The Python extension module posix_ipc gives access to POSIX + inter-process semaphores, shared memory and message queues + on systems that support the POSIX Realtime Extensions + a.k.a. POSIX 1003.1b-1993. + + http://semanchuk.com/philip/posix_ipc/ diff --git a/package/python-posix-ipc/python-poxix-ipc.mk b/package/python-posix-ipc/python-poxix-ipc.mk new file mode 100644 index 0000000..24518b2 --- /dev/null +++ b/package/python-posix-ipc/python-poxix-ipc.mk @@ -0,0 +1,14 @@ +################################################################################ +# +# python-posix-ipc +# +################################################################################ + +PYTHON_POSIX_IPC_VERSION = 0.9.6 +PYTHON_POSIX_IPC_SOURCE = posix_ipc-$(PYTHON_POSIX_IPC_VERSION).tar.gz +PYTHON_POSIX_IPC_SITE = http://semanchuk.com/philip/posix_ipc/ +PYTHON_POSIX_IPC_LICENSE = BSD-2c +PYTHON_POSIX_IPC_LICENSE_FILES = LICENSE +PYTHON_POSIX_IPC_SETUP_TYPE = distutils + +$(eval $(python-package))
This patch is based on the original new pkg patch submitted last Jan and is part of the "Patchwork oldest patches cleanup #5". It combines the original "[1/2]/[2/2] new package: python-posix_ipc" patch files. The libc wrapper code is written in C has dependencies on the rt lib. Signed-off-by: Matt Weber <mlweber1@rockwellcollins.com> --- package/Config.in | 1 + package/python-posix-ipc/Config.in | 10 ++++++++++ package/python-posix-ipc/python-poxix-ipc.mk | 14 ++++++++++++++ 3 files changed, 25 insertions(+), 0 deletions(-) create mode 100644 package/python-posix-ipc/Config.in create mode 100644 package/python-posix-ipc/python-poxix-ipc.mk